Reuse config deserialization logic across filters #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates CreateFilterArgs to contain either static or proto filter config using an enum. Add a function to deserialize the config enum, returning the static version regardless of input type. This function requires that the static config can be created from the proto type. Update all filters with proto config type TODO as they do not yet have proto configs.
markmandel
reviewed
Feb 2, 2021
| /// metrics_registry is used to register filter metrics collectors. | ||
| pub metrics_registry: Registry, | ||
| } | ||
|
|
||
| impl CreateFilterArgs<'_> { | ||
| pub fn new(config: Option<&serde_yaml::Value>) -> CreateFilterArgs { | ||
| pub fn fixed(config: Option<&serde_yaml::Value>) -> CreateFilterArgs { |
There was a problem hiding this comment.
Shame we can't call it static - I even went to double check it, but it's a keyword!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates CreateFilterArgs to contain either static or proto filter
config using an enum.
Add a function to deserialize the config enum, returning the static
version regardless of input type. This function requires that the
static config can be created from the proto type. Update all filters
with proto config type TODO as they do not yet have proto configs.