Upgrade to Tokio 1.0

[markmandel]

Upgrade Tokio and dependent libraries to 1.0

Also took the opportunity to bring some naming to consistency when
updating api calls for the change to 1.0

[markmandel]

I've got one compilation issue I can't seem to work out:

quilkin/src/xds/ads_client.rs

Lines 302 to 317 in 13e383d

	fn run_receive_loop(
	log: Logger,
	mut client: AggregatedDiscoveryServiceClient<TonicChannel>,
	rpc_rx: mpsc::Receiver<DiscoveryRequest>,
	mut resource_handlers: ResourceHandlers,
	mut backoff: ExponentialBackoff<SystemClock>,
	mut shutdown_rx: watch::Receiver<()>,
	) -> JoinHandle<RpcSessionResult> {
	tokio::spawn(async move {
	let mut response_stream = match client
	.stream_aggregated_resources(Request::new(rpc_rx))
	.await
	{
	Ok(response) => response.into_inner(),
	Err(err) => return Err(RpcSessionError::Receive(resource_handlers, backoff, err)),
	};

error[E0277]: the trait bound `tonic::Request<tokio::sync::mpsc::Receiver<xds::envoy::service::discovery::v3::DiscoveryRequest>>: tonic::IntoStreamingRequest` is not satisfied
   --> src/xds/ads_client.rs:312:46
    |
312 |                 .stream_aggregated_resources(Request::new(rpc_rx))
    |                                              ^^^^^^^^^^^^^^^^^^^^ the trait `tonic::IntoStreamingRequest` is not implemented for `tonic::Request<tokio::sync::mpsc::Receiver<xds::envoy::service::discovery::v3::DiscoveryRequest>>`
    |
    = help: the following implementations were found:
              <tonic::Request<T> as tonic::IntoStreamingRequest>

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.

@iffyio got any ideas? I poked at this for a few hours, and I'm drawing blanks.

For some reason the mspc::Receiver doesn't implement a https://docs.rs/tonic/0.4.0/tonic/trait.IntoStreamingRequest.html? But not matter what I do, I can't seem to get it to become an iterator... which I think should work? I'm stuck on this one 😞

[markmandel]

Realised I was running just cargo clippy and not cargo clippy --tests - this updates the tests 👍

[markmandel]

Worked it out 🤸 needed ReceiverStream from tokio-stream crate, and it seems to be compiling now. It was just hiding some more things to tweak!

[markmandel]

This should be good for review! That was fun.

[iffyio]

Looks great! 🎉

[iffyio]

Suggested change

	/// The socket
	/// The opened socket

[iffyio]

Yay! I won't miss this pattern 😂

[markmandel]

Me too! 😁

[iffyio]

I've got one compilation issue I can't seem to work out:

quilkin/src/xds/ads_client.rs

Lines 302 to 317 in 13e383d

	fn run_receive_loop(
	log: Logger,
	mut client: AggregatedDiscoveryServiceClient<TonicChannel>,
	rpc_rx: mpsc::Receiver<DiscoveryRequest>,
	mut resource_handlers: ResourceHandlers,
	mut backoff: ExponentialBackoff<SystemClock>,
	mut shutdown_rx: watch::Receiver<()>,
	) -> JoinHandle<RpcSessionResult> {
	tokio::spawn(async move {
	let mut response_stream = match client
	.stream_aggregated_resources(Request::new(rpc_rx))
	.await
	{
	Ok(response) => response.into_inner(),
	Err(err) => return Err(RpcSessionError::Receive(resource_handlers, backoff, err)),
	};

error[E0277]: the trait bound `tonic::Request<tokio::sync::mpsc::Receiver<xds::envoy::service::discovery::v3::DiscoveryRequest>>: tonic::IntoStreamingRequest` is not satisfied
   --> src/xds/ads_client.rs:312:46
    |
312 |                 .stream_aggregated_resources(Request::new(rpc_rx))
    |                                              ^^^^^^^^^^^^^^^^^^^^ the trait `tonic::IntoStreamingRequest` is not implemented for `tonic::Request<tokio::sync::mpsc::Receiver<xds::envoy::service::discovery::v3::DiscoveryRequest>>`
    |
    = help: the following implementations were found:
              <tonic::Request<T> as tonic::IntoStreamingRequest>

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.

@iffyio got any ideas? I poked at this for a few hours, and I'm drawing blanks.

For some reason the mspc::Receiver doesn't implement a https://docs.rs/tonic/0.4.0/tonic/trait.IntoStreamingRequest.html? But not matter what I do, I can't seem to get it to become an iterator... which I think should work? I'm stuck on this one

Missed this comment earlier :P will have a look

[iffyio]

Worked it out needed ReceiverStream from tokio-stream crate, and it seems to be compiling now. It was just hiding some more things to tweak!

No wait, it was already solved, I confused myself there for a sec 😅

[markmandel]

Just tracking potential flakiness:

failures:

---- extensions::filters::local_rate_limit::tests::token_refill_maximum stdout ----
thread 'extensions::filters::local_rate_limit::tests::token_refill_maximum' panicked at 'assertion failed: `(left == right)`
  left: `None`,
 right: `Some(())`', src/extensions/filters/local_rate_limit/mod.rs:265:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- extensions::filters::local_rate_limit::tests::token_exhaustion_and_refill stdout ----
thread 'extensions::filters::local_rate_limit::tests::token_exhaustion_and_refill' panicked at 'assertion failed: `(left == right)`
  left: `None`,
 right: `Some(())`', src/extensions/filters/local_rate_limit/mod.rs:242:9


failures:
    extensions::filters::local_rate_limit::tests::token_exhaustion_and_refill
    extensions::filters::local_rate_limit::tests::token_refill_maximum

Will keep an eye on it, and see how often it pops up.