Update proxy configuration format #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
reviewed
Nov 25, 2020
Update proxy configuration format Update tests and docs Merge the server/client configuration example Fixes #130
iffyio
force-pushed
the
iu/proxy-config
branch
from
7f43a99 to
597e723
Compare
iffyio
commented
Nov 25, 2020
markmandel
reviewed
Nov 30, 2020
| } | ||
|
|
||
| #[derive(Debug, Deserialize, Serialize)] | ||
| pub struct AdminAddress { |
| @@ -36,6 +36,7 @@ pub mod external_doc_tests { | |||
| // it is only available using a nightly compiler. | |||
| // To run them locally run e.g `cargo +nightly test --doc` | |||
| #![doc(include = "../docs/extensions/filters/filters.md")] | |||
| #![doc(include = "../docs/extensions/filters/load_balancer.md")] | |||
| connection: &'a ConnectionConfig, | ||
| config: Option<&'a serde_yaml::Value>, | ||
| ) -> CreateFilterArgs<'a> { | ||
| pub fn new(config: Option<&serde_yaml::Value>) -> CreateFilterArgs { |
There was a problem hiding this comment.
The idea behind passing through the ConnectionConfig was so that Filters would be able to know if they are in client or server mode.
Is it worth adding that back in here (pass in the ProxyMode)? Or should we do it with whatever PR actually needs that information?
There was a problem hiding this comment.
Ah, yes it rings a bell now I remember we had some feature in mind that wanted it. We can include it back in the PR that needs it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update proxy configuration format
Update tests and docs
Merge the server/client configuration example
Fixes #130
Currently contains #140 so will keep in draft until that's merged