Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace oneshot shutdown signal with watch channel #129

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Replace oneshot shutdown signal with watch channel #129

merged 2 commits into from
Nov 11, 2020

Conversation

iffyio
Copy link
Collaborator

@iffyio iffyio commented Nov 7, 2020

We need a single shutdown signal and oneshot doesn't allow
this so we use a watch channel instead.

@iffyio
Replace oneshot shutdown signal with watch channel
60d4dab 
We need a single shutdown signal and oneshot doesn't allow
this so we use a watch channel instead.
@iffyio iffyio requested a review from markmandel November 7, 2020 18:28
@google-cla google-cla bot added the cla: yes label Nov 7, 2020
markmandel
markmandel approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy approve!

@markmandel markmandel merged commit 9464493 into master Nov 11, 2020
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Nov 11, 2020
@markmandel markmandel deleted the iu/shutdown-watch branch May 2, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
cla: yes kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iffyio @markmandel