Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DebugFilter -> Debug to avoid redundancy #113

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Rename DebugFilter -> Debug to avoid redundancy #113

merged 2 commits into from
Oct 21, 2020

Conversation

markmandel
Copy link
Contributor

Seemed redundant to have Filter in both the package name and the name of Debug.

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 20, 2020
@google-cla google-cla bot added the cla: yes label Oct 20, 2020
@markmandel
Rename DebugFilter -> Debug to avoid redundancy
efb301f 
Seemed redundant to have Filter in both the package name and the name of
Debug.
@markmandel markmandel force-pushed the cleanup/debugfilter-debug branch from 5a589ee to efb301f Compare October 20, 2020 00:50
@markmandel
Copy link
Contributor Author

Note - ended up having to switch to 200 depth on proto/googleapis as CI was unable to find the commit.

@markmandel markmandel merged commit 76c1ab7 into master Oct 21, 2020
@markmandel markmandel deleted the cleanup/debugfilter-debug branch October 21, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iffyio iffyio iffyio approved these changes

Assignees
No one assigned
Labels
cla: yes kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markmandel @iffyio