Concat Byte Filter #111
Merged
Concat Byte Filter #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
kind/feature
iffyio
reviewed
Sep 21, 2020
|
Just pushed up the change to SCREAMING_SNAKE_CASE, in case that's what we feel good about 😄 |
The `ConcatBytes` filter's job is to add a byte packet to either the beginning or end of each UDP packet that passes through. This is commonly used to provide an auth token to each packet, so they can be routed appropriately. This also includes implementing `Filter` on `Box` to make reusable test assertion functions easier to write. Next step will be to remove `connection_id` from the Client config. Work on #8
Moving to SCREAMING_SNAKE_CASE for the enums.
markmandel
force-pushed
the
feature/concat_bytes
branch
from
e4b8858 to
152c404
Compare
|
I think that should do the trick 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConcatBytesfilter's job is to add a byte packet to either the beginning or end of each UDP packet that passes through. This is commonly used to provide an auth token to each packet, so they can be routed appropriately.This also includes implementing
FilteronBoxto make reusable test assertion functions easier to write.Next step will be to remove
connection_idfrom the Client config.Work on #8