Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xds proto code generation #108

Merged
merged 6 commits into from
Oct 14, 2020
Merged

Add xds proto code generation #108

merged 6 commits into from
Oct 14, 2020

Conversation

iffyio
Copy link
Collaborator

@iffyio iffyio commented Sep 17, 2020

Work on #10

@iffyio iffyio requested a review from markmandel September 17, 2020 17:26
markmandel
markmandel approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as approved, so you can merge it if/when you want to make that small change I noticed.

@markmandel markmandel added area/build-tools Development tooling. kind/feature New feature or request labels Oct 12, 2020
iffyio and others added 2 commits October 14, 2020 18:35
@iffyio @markmandel
Update src/xds/mod.rs
6d2fe04 
Co-authored-by: Mark Mandel <markmandel@google.com>
@iffyio
Merge branch 'master' into iu/xds-skeleton
6ccb15c
@iffyio iffyio merged commit 5997d4d into master Oct 14, 2020
@markmandel markmandel deleted the iu/xds-skeleton branch October 18, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. cla: yes kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iffyio @markmandel @googlebot