Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GRPC proto submodules #105

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Add GRPC proto submodules #105

merged 3 commits into from
Sep 17, 2020

Conversation

iffyio
Copy link
Collaborator

@iffyio iffyio commented Sep 12, 2020

Also fetch them in CI

@iffyio
Add GRPC proto submodules
28f5f5f 
Also fetch them in CI
@iffyio iffyio requested a review from markmandel September 12, 2020 11:46
markmandel
markmandel approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as approved -- if the --depth trick might be a nice optimisation, please add, otherwise, go ahead and merge 👍

cloudbuild.yaml Outdated Show resolved Hide resolved
@markmandel markmandel added the kind/feature New feature or request label Sep 16, 2020
@iffyio iffyio merged commit be64ddb into master Sep 17, 2020
@iffyio iffyio deleted the iu/submodules branch May 16, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
cla: yes kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iffyio @markmandel @googlebot