Pass context objects in filter APIs #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the objects are exposed to the filter API we would like to be able to control how they're created so that we don't break code whenever we e.g add new fields - for this we use phantoms, we might also need to make the `Context::new()` constructors private from the filter functions since a filter shouldn't need to create them to begin with. Fixes #94
markmandel
approved these changes
Sep 11, 2020
| /// Contents of the received packet. | ||
| pub contents: Vec<u8>, | ||
| // Enforce using constructor to create this struct. | ||
| phantom: PhantomData<()>, |
There was a problem hiding this comment.
Always learning new stuff 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the objects are exposed to the filter API we would
like to be able to control how they're created so that we don't
break code whenever we e.g add new fields - for this we use
phantoms, we might also need to make the
Context::new()constructorsprivate from the filter functions since a filter shouldn't need
to create them to begin with.
Fixes #94