Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: More explicit container caching #1001

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

markmandel
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature

What this PR does / Why we need it:

Just being explicit, not implicit with container caching.

Just a bit of cleanup

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Checking if cloudbuild still caches as expected before moving to full PR.

Just being explicit, not implicit with container caching.

Just a bit of cleanup
@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/xs labels Aug 16, 2024
@markmandel markmandel marked this pull request as ready for review August 16, 2024 15:57
@markmandel
Copy link
Contributor Author

Good to go. Merge whenever.

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: b8427298-8da5-4f08-9114-c6d20582cdf3

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/1001/head:pr_1001 && git checkout pr_1001
cargo build

@XAMPPRocky XAMPPRocky merged commit bc0eeeb into googleforgames:main Aug 16, 2024
10 checks passed
@markmandel markmandel deleted the build/caching branch August 17, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants