Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cargo Deny to make test #327

Closed
markmandel opened this issue Jul 9, 2021 · 0 comments · Fixed by #340
Closed

Add Cargo Deny to make test #327

markmandel opened this issue Jul 9, 2021 · 0 comments · Fixed by #340
Labels
area/tests Unit tests, integration tests, anything to make sure things don't break priority/low Issues that don't need to be addressed in the near term.

Comments

@markmandel
Copy link
Contributor

We have a #239 cargo deny configuration, but it's not integrated into our CI or local testing tooling.

If we add a new target to build/Makefile and make it a dependency of the test target, it will also be tracked in CI as well.
@markmandel markmandel added the area/tests Unit tests, integration tests, anything to make sure things don't break label Jul 9, 2021
@XAMPPRocky XAMPPRocky added the priority/low Issues that don't need to be addressed in the near term. label Jul 12, 2021
This was referenced Jul 19, 2021
Merged
Merged
markmandel added a commit that referenced this issue Jul 20, 2021
@markmandel
Add cargo-deny to CI by adding to make test (#340)
36be5eb 
This adds `cargo-deny` to `make test`, which also makes sure it is run
in Cloud Build for continuous integration.

This found a couple of dependencies that need to be updated because of
security advisories. These will be updated in a separate PR.

Closes #327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tests Unit tests, integration tests, anything to make sure things don't break priority/low Issues that don't need to be addressed in the near term.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cargo-deny to CI by adding to make test googleforgames/quilkin
2 participants
@markmandel @XAMPPRocky