Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convention: quilkin.yaml file #270

Closed
XAMPPRocky opened this issue May 20, 2021 · 4 comments · Fixed by #279
Closed

Convention: quilkin.yaml file #270

XAMPPRocky opened this issue May 20, 2021 · 4 comments · Fixed by #279
Labels
kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New feature or request

Comments

@XAMPPRocky
Copy link
Collaborator

While working on the project I usually have a yaml that I use to develop on it, and it's slightly annoying to have to keep git from checking it in. So I would like to propose that we use quilkin.yaml as the default filename for quilkin configuration, and add quilkin.yaml to the .gitignore. We could also change --filename to look at quilkin.yaml by default.

@iffyio
Copy link
Collaborator

iffyio commented May 20, 2021

This sounds reasonable to me!

@markmandel
Copy link
Contributor

This is the only https://github.com/googleforgames/quilkin/blob/main/build/release/quilkin.yaml I could find in the repo currently.

But otherwise, no objection here.

@XAMPPRocky
Copy link
Collaborator Author

XAMPPRocky commented May 20, 2021

We can still have quilkin.yaml's in repository, I think just reserving the top level is the most important in terms of development.

@markmandel
Copy link
Contributor

We can still have quilkin.yaml's in repository, I think just reserving the top level is the most important in terms of development.

👍🏻 just highlighting is just in case it gets caught up in an ignore rule accidentally.

XAMPPRocky added a commit that referenced this issue May 25, 2021
XAMPPRocky added a commit that referenced this issue May 25, 2021
XAMPPRocky added a commit that referenced this issue May 25, 2021
XAMPPRocky added a commit that referenced this issue May 26, 2021
@markmandel markmandel added kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New feature or request labels Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants