Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Filter to have read and write methods #192

Closed
markmandel opened this issue Feb 13, 2021 · 0 comments · Fixed by #194
Closed

Refactor Filter to have read and write methods #192

markmandel opened this issue Feb 13, 2021 · 0 comments · Fixed by #194
Assignees
@markmandel
Labels
kind/cleanup Refactoring code, fixing up documentation, etc

Comments

@markmandel
Copy link
Contributor

Context: #188 (comment)

TL;DR:

  • Aligns with Envoy concepts
  • Removes confusion around "upsteam" and "downsteam" configuration, as it doesn't reuse the concepts in a non-aligned way.
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 13, 2021
@markmandel markmandel self-assigned this Feb 13, 2021
@markmandel markmandel mentioned this issue Feb 13, 2021
Closed
markmandel added a commit that referenced this issue Feb 15, 2021
@markmandel
Rename Filter to align with Envoy concepts
5b7cf5b 
Refactor `on_downstream_receive` to `read` and `on_upstream_receive` to
`write`, to align with Envoy concepts, and remove confusion about
`upstream` and `downstream`.

Also renamed corresponding `Contexts` and `Responses` to align with new
`Read` and `Write` terminology as well.

Closes #192
@markmandel markmandel mentioned this issue Feb 15, 2021
Merged
iffyio pushed a commit that referenced this issue Feb 16, 2021
@markmandel
Rename Filter to align with Envoy concepts (#194)
084ef55 
Refactor `on_downstream_receive` to `read` and `on_upstream_receive` to
`write`, to align with Envoy concepts, and remove confusion about
`upstream` and `downstream`.

Also renamed corresponding `Contexts` and `Responses` to align with new
`Read` and `Write` terminology as well.

Closes #192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markmandel markmandel

Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Filter to align with Envoy concepts googleforgames/quilkin
1 participant
@markmandel