Add the missing functions to the C++ SDK (Allocated & Reserve) #948
Conversation
|
Build Succeeded 👏 Build Id: e0cd0ca7-f3f2-4b26-b349-794e6d88c3a6 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
| @@ -39,6 +39,13 @@ class SDK { | |||
| // Marks the Game Server as ready to receive connections | |||
| AGONES_EXPORT grpc::Status Ready(); | |||
|
|
|||
| // Self marks this gameserver as Allocated. | |||
There was a problem hiding this comment.
"self marks" is a phrase -- basically instead of having the gameserver be allocated through the allocation service, the gameserver does the allocation itself. The comment matches the comment in the go sdk (as do all of the other comments in this file).
There was a problem hiding this comment.
Can we please also update the docs here? https://agones.dev/site/docs/guides/client-sdks/cpp/
roberthbailey
force-pushed
the
cpp-sdk-fns
branch
from
d5a7235
to
4800591
Compare
Done. |
|
Build Failed 😱 Build Id: 6c55f5b0-9df9-4912-97ae-8d8ec8cb48f2 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Looks like the reserve link will need to be done as a ... See: https://github.com/wjdp/htmltest#see_no_evil-ignoring-content |
roberthbailey
force-pushed
the
cpp-sdk-fns
branch
from
4800591
to
066412d
Compare
|
Fixed the link for reserve. |
|
Build Succeeded 👏 Build Id: d5089c7f-cdeb-4e75-98ce-b98ea1c77712 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
added
area/user-experience
Part of #927.
Since the C++ SDK doesn't have any automated tests, I tested this manually by modifying the simple-cpp example to call Allocate / Reserve instead of Ready when starting up, and then verified that the gameserver made the expected state transitions.