Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kind dev tooling to 1.12 #896

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Update kind dev tooling to 1.12 #896

merged 2 commits into from
Jul 15, 2019

Conversation

roberthbailey
Copy link
Member

Part of #717.

A couple of notes:

  1. The go get install instructions didn't work for me, so instead of trying to keep our instructions up to date I just replaced it with a link to the Kind docs (it turns out they switched to go modules, which was why).
  2. The current version of kind (v0.4.0) doesn't successfully create clusters at 1.11.3 any longer so that was broken.
  3. I tried to use 1.12.10 (the latest 1.12 release) but kind only seems to support 1.12.9.

@roberthbailey roberthbailey changed the title Update kind documentation and dev tooling to 1.12 Update kind dev tooling to 1.12 Jul 10, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 34d2cb37-2d85-46d5-995e-abc8d3d58d9a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/896/head:pr_896 && git checkout pr_896
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-63d5aa0

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3d16210d-d1f4-4953-9de3-ae4f839d4407

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/896/head:pr_896 && git checkout pr_896
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-ed88749

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 96f0e785-2388-45e3-8ce2-d71695180b5b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/896/head:pr_896 && git checkout pr_896
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-bb72205

@markmandel
Copy link
Member

I'll take this for a spin, but @Kuqd did you also want to look, since KinD was your baby?

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6e421a66-fbc8-4cf1-a1b5-a2160b16ae54

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 75fe2dbf-32ea-413c-8ec4-f1e16b10e1fe

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7d5bdb0c-64fe-44dd-a385-294c8fc781da

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/896/head:pr_896 && git checkout pr_896
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-a6ff53b

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9714356e-fc1e-4858-b596-15931cfa6fe3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/896/head:pr_896 && git checkout pr_896
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-87522c2

cyriltovena
cyriltovena approved these changes Jul 15, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have another fix in my branch for the allocator to run as nodeport instead of loadbalancer, possibly in 1.12.9 loadbalancer service type is supported.

@roberthbailey
Copy link
Member Author

Kind does not appear to have support for type loadbalancer (see kubernetes-sigs/kind#411) so it'd be great to get your change upstreamed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4868f812-d450-4c8c-a16d-b4bb8d991328

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/896/head:pr_896 && git checkout pr_896
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-20a269f

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/documentation Documentation for Agones labels Jul 15, 2019
@markmandel markmandel added this to the 0.12.0 milestone Jul 15, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9fdd5d86-d699-42ef-bdb3-e022d24870e3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/896/head:pr_896 && git checkout pr_896
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-c42195f

@markmandel markmandel merged commit aaa7e8a into googleforgames:master Jul 15, 2019
@roberthbailey roberthbailey mentioned this pull request Jul 16, 2019
Closed
5 tasks
@roberthbailey roberthbailey deleted the kind-to-1-12 branch August 1, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@roberthbailey @agones-bot @markmandel @cyriltovena