Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CPP Example Readme and yaml files #847

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Update CPP Example Readme and yaml files #847

merged 2 commits into from
Jul 2, 2019

Conversation

markmandel
Copy link
Member

Update incorrect instructions for building the examples, and
also update fleet.yaml and gameserver.yaml to the correct image
tag.

@markmandel
Update CPP Example Readme and yaml files
8106ffe 
Update incorrect instructions for building the examples, and
also update fleet.yaml and gameserver.yaml to the correct image
tag.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/examples Examples. Usually found in the `examples` directory labels Jun 21, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a4537385-e8b1-423e-84f3-b6aee1cedd0e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7cf99fc4-2738-4d4d-bfbd-4b9a7df6d14c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/847/head:pr_847 && git checkout pr_847
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-8106ffe

@roberthbailey
Copy link
Member

lgtm

ilkercelikyilmaz
ilkercelikyilmaz approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@ilkercelikyilmaz ilkercelikyilmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel added this to the 0.12.0 milestone Jul 2, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 965c21a1-b3f8-491f-bcb3-73c31ecfb54d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 62f0b510-48d1-45c9-a401-f4c992f69539

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 50e6f491-a6d9-46a9-a4f4-5b0dbb582c16

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/847/head:pr_847 && git checkout pr_847
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-7f34833

@markmandel markmandel merged commit 2dc1bb3 into googleforgames:master Jul 2, 2019
@markmandel markmandel deleted the readme/cpp-example branch July 2, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilkercelikyilmaz ilkercelikyilmaz ilkercelikyilmaz approved these changes

Assignees
No one assigned
Labels
area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @roberthbailey @ilkercelikyilmaz