Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proto directory and update tooling. #709

Merged
merged 2 commits into from
Apr 16, 2019
Merged

Add proto directory and update tooling. #709

merged 2 commits into from
Apr 16, 2019

Conversation

heartrobotninja
Copy link
Contributor

Fixes one part of #695 and #630 where proto files are no longer in the vendor directory.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a7f56186-42e8-4e84-8f99-a2641326186a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/709/head:pr_709 && git checkout pr_709
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-27fafa5

@markmandel
Copy link
Member

Should the proto files also be included in this PR?

@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/bug These are bugs. labels Apr 16, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 59823ee9-cb6f-4560-a113-0275630aa5be

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Adding proto files to proto directory

Adding proto files to proto directory
@heartrobotninja
Copy link
Contributor Author

Ugh, I thought they were on this. Added and squashed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 55c76030-8955-42b1-8a17-f13731e8291d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/709/head:pr_709 && git checkout pr_709
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-aad3ddd

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3673acc2-02ce-4f4d-89e1-9b8f9cf5b826

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 577d0010-52fa-4cc5-a470-cedf0713d149

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/709/head:pr_709 && git checkout pr_709
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-0c75b5a

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally, works! 🍰

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7b0153b9-e210-4c50-9857-8a9cb12d7ebb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/709/head:pr_709 && git checkout pr_709
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-b92039a

@markmandel markmandel merged commit b8242b0 into googleforgames:master Apr 16, 2019
@markmandel markmandel added this to the 0.10.0 milestone Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/bug These are bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants