Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update issue templates #708

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Update issue templates #708

merged 2 commits into from
Apr 25, 2019

Conversation

thisisnotapril
Copy link
Collaborator

No description provided.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5bcd00e4-2d26-435d-82dd-18d72c80b3ee

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/708/head:pr_708 && git checkout pr_708
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-699e6e2

markmandel
markmandel reviewed Apr 16, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome 💯 just had a couple of minor adjustments I think would work better.

WDYT?

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.md Outdated Show resolved Hide resolved
@markmandel
Copy link
Member

Oh, should we update .gitignore to specifically track the !.github folder?

@markmandel markmandel added the area/meta Organisational matters. e.g. Governance, release cycles, etc. label Apr 16, 2019
@thisisnotapril thisisnotapril self-assigned this Apr 22, 2019
@thisisnotapril
Copy link
Collaborator Author

@markmandel updates made, please take a look

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 28720c9a-3664-4439-9a0c-75020e01c757

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9f4db444-bb27-4d94-bb50-c7b4c590ae3c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: aa4c7470-c6cf-40f2-bd85-de3fcd74672c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/708/head:pr_708 && git checkout pr_708
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-0817257

markmandel
markmandel reviewed Apr 23, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will also need to add this folder to be explicitly included in .gitignore - otherwise changes to it will be skipped (which would make us sad).

And we'll need to squash this down to a single commit as per contributor guidelines please 👍

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8125afad-860d-4e6d-8079-6f01867ca29c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 381b9a61-ae04-4de3-b2dd-ae4acdccd4fb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 327ec7ac-3e8f-4521-9f1d-0cc3a3dfe2c3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/708/head:pr_708 && git checkout pr_708
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-bfdcfba

markmandel
markmandel approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markmandel markmandel merged commit da4fb8d into master Apr 25, 2019
@markmandel markmandel added this to the 0.10.0 milestone Apr 27, 2019
@markmandel markmandel deleted the thisisnotapril-patch-1 branch May 1, 2019 17:55
@roberthbailey roberthbailey mentioned this pull request May 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees

@thisisnotapril thisisnotapril

Labels
area/meta Organisational matters. e.g. Governance, release cycles, etc.
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thisisnotapril @agones-bot @markmandel