Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feature shortcode for Hugo #655

Merged
merged 1 commit into from
Mar 16, 2019
Merged

Fix feature shortcode for Hugo #655

merged 1 commit into from
Mar 16, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Mar 15, 2019

Algorithm for splitting version strings by dots and comparing major, minor versions one by one separately. There is no break statement for range loop in Hugo functions, that's why added special handling for that case.

Closes #650 .

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 311a060e-858b-4e4f-a73f-2e1e689c1939

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/655/head:pr_655 && git checkout pr_655
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-d356422

@aLekSer
Copy link
Collaborator Author

aLekSer commented Mar 15, 2019

By default if we access element over the list length we would get 0 - and this would make shortcode work even for version = 1.99.0 and publishVersion = 1.9. In this function $p=0 (length of publDigits is 3):

    {{- $p := int (index $publDigits 4)}}

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ba1e0851-a3d2-496d-afb9-e88ab6229b60

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/655/head:pr_655 && git checkout pr_655
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-6f8ae99

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ebfa7498-112b-4fcf-aa1f-5219bcad8812

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/655/head:pr_655 && git checkout pr_655
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-74dd7e4

@aLekSer
Fix feature shortcode for Hugo
02356ab 
Algorithm for splitting string by dots and comparing major, minor
version one by one separately. There is no break statement for
range loop, that's why added special handling for that case.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 550b10f9-0d42-46c1-afa8-b4ee5bf408f5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/655/head:pr_655 && git checkout pr_655
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-02356ab

markmandel
markmandel approved these changes Mar 16, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@markmandel markmandel merged commit fb148fc into googleforgames:master Mar 16, 2019
@markmandel markmandel added area/site The website itself - including redirects, styling, search, etc kind/bug These are bugs. labels Mar 26, 2019
@markmandel markmandel added this to the 0.9.0 milestone Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/site The website itself - including redirects, styling, search, etc kind/bug These are bugs.
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aLekSer @agones-bot @markmandel