C++ SDK cross-platform build #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
Build Failed 😱 Build Id: b6681eab-6be5-4076-a1dd-f033f132ee88 Build Logs |
|
CLA signed, please review. |
|
CLAs look good, thanks! |
|
Build Failed 😱 Build Id: ff1c09b3-1990-448e-9ce0-185e87a015c7 Build Logs |
markmandel
added
the
feature-freeze-do-not-merge
markmandel
removed
feature-freeze-do-not-merge
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Dec 1, 2018
In preparation for googleforgames#421, this updates gRPC (and associated libraries) to v1.16.1. This also updates the simple-udp, cpp-simple and xonotic examples as well.
Merged
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Dec 1, 2018
In preparation for googleforgames#421, this updates gRPC (and associated libraries) to v1.16.1. This also updates the simple-udp, cpp-simple and xonotic examples as well.
markmandel
added a commit
that referenced
this pull request
Dec 3, 2018
In preparation for #421, this updates gRPC (and associated libraries) to v1.16.1. This also updates the simple-udp, cpp-simple and xonotic examples as well.
|
Closing this, as we now have #464 , and new changes are happening on that PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset removes the old Makefile-based build and replaces it by a CMake build that works across Windows, Linux and macOS.