Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process to become an reviewer/approver on Agones. #399

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Process to become an reviewer/approver on Agones. #399

merged 2 commits into from
Oct 31, 2018

Conversation

markmandel
Copy link
Member

This is a first draft of a process for adding more reviewers to the this project.

Outlines requirements for consideration, as well as responsibilities.

Feedback much appreciated!

I've chosen some of the numbers around contribution somewhat arbitrarily -- would definitely love feedback on if you think they are too high/too low.

@markmandel markmandel added the area/meta Organisational matters. e.g. Governance, release cycles, etc. label Oct 25, 2018
@markmandel markmandel added this to the 0.6.0 milestone Oct 25, 2018
@markmandel
Copy link
Member Author

/cc @thisisnotapril - would love your feedback here.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a7fb0260-99eb-41cb-8f85-757e85196421

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/399/head:pr_399 && git checkout pr_399
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.6.0-43cf531

@cyriltovena
Copy link
Collaborator

Nice one !

@markmandel
Process to become an reviewer/approver on Agones.
85b77bb 
This is a first draft of a process for adding more reviewers to the this project.

Outlines requirements for consideration, as well as responsibilities.

Feedback much appreciated!
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1ad70906-1305-486c-b76c-1ebfbf22361f

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/399/head:pr_399 && git checkout pr_399
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.6.0-85b77bb

@thisisnotapril
Copy link
Collaborator

/cc @thisisnotapril - would love your feedback here.

looks good! yay for roles!

@markmandel
Copy link
Member Author

Seems like everyone is quite happy with this. Awesome!

Can I has an approval please? 😄

cyriltovena
cyriltovena approved these changes Oct 31, 2018
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got it

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 64be56e7-2899-4cf3-acfe-008bfea31022

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/399/head:pr_399 && git checkout pr_399
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.6.0-1287c24

@markmandel markmandel merged commit c2278b7 into googleforgames:master Oct 31, 2018
@markmandel markmandel deleted the meta/new-contributor branch October 31, 2018 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/meta Organisational matters. e.g. Governance, release cycles, etc.
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @cyriltovena @thisisnotapril