Upgrade to Golang Version 1.22.6 and Golangci lint version v1.61.0 #3988

0xaravindh · 2024-09-17T08:46:55Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes: #3949

Closes #3949

Special notes for your reviewer:

github-actions · 2024-09-17T08:47:13Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-09-17T08:54:22Z

Build Failed 😭

Build Id: 67ba3955-fb92-4676-bf05-3c83802b6a08

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-09-19T04:26:09Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-09-19T04:37:03Z

Build Failed 😭

Build Id: e12c0ed2-f2c2-41a3-a2e4-e6e60a3d4892

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-09-19T08:52:50Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-09-19T09:02:33Z

Build Failed 😭

Build Id: 6c603335-9d25-4523-adc5-4c66220d84e7

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

…ngci-lint-version-update

github-actions · 2024-09-23T13:57:56Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-09-23T14:06:10Z

Build Failed 😭

Build Id: 0a32a258-5f3e-4fbc-bf0a-5ecdfb33f86e

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

peterzhongyi · 2024-09-23T17:31:19Z

go.mod

@@ -1,6 +1,8 @@
 module agones.dev/agones

-go 1.21
+go 1.22.0


Does this need to be 1.22 instead of 1.22.0?

updated @peterzhongyi

github-actions · 2024-09-27T22:09:11Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-09-27T22:18:36Z

Build Failed 😭

Build Id: f13958d5-bab5-451f-9e15-781285f3fab0

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-09-30T06:12:04Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-09-30T06:16:49Z

Build Failed 😭

Build Id: 51bc6965-3c3d-4b41-a2d0-52cce6e257f3

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-10-01T13:05:08Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-10-01T13:11:16Z

Build Failed 😭

Build Id: 7de13ef0-54d5-4538-b972-af6ab21a2b93

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-10-01T13:30:05Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-10-01T13:45:07Z

Build Failed 😭

Build Id: 6956a2d6-510d-43da-a3c4-1086cf05f866

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-10-01T15:56:19Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-10-01T16:47:14Z

Build Failed 😭

Build Id: 8da229b7-744f-443f-a8fa-51e22435926c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-10-02T18:56:51Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-10-02T19:11:47Z

Build Failed 😭

Build Id: 290c6dd1-aafe-4bd5-b133-f13d742d236a

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-10-02T23:38:19Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-10-03T00:29:11Z

Build Failed 😭

Build Id: b1a6b6d2-a65c-440b-b8e8-a52ac5d415b6

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-10-03T08:52:43Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-10-03T09:52:06Z

Build Succeeded 🥳

Build Id: 6263372e-cc1a-48f1-aa83-262263365f03

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.44.0-dev-17896ed
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.44.0-dev-17896ed
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.44.0-dev-17896ed-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.44.0-dev-17896ed
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.44.0-dev-17896ed
Linux C++ SDK (build): agonessdk-1.44.0-dev-17896ed-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.44.0-dev-17896ed.zip

A preview of the website (the last 30 builds are retained):

https://17896ed-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3988/head:pr_3988 && git checkout pr_3988
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-17896ed

gongmax

LGTM. Some minor comments for my learning purpose.

cmd/allocator/main.go

cmd/sdk-server/main.go

sdks/swagger/beta.swagger.json

0xaravindh added 7 commits September 13, 2024 04:09

update_goversion_go.mod_go.sum

f49b5eb

updated_build_dockerfile_goversion

8a3bbec

updated_example_dockerfile_goversion

e78c37c

update_the_example_images_tag

0beb430

Update the k8s error handler

a5afc3e

Merge branch 'googleforgames:main' into main

8154246

v1.61.0 update

0e7e5c0

github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XL labels Sep 17, 2024

0xaravindh requested review from markmandel, gongmax and peterzhongyi September 17, 2024 08:48

0xaravindh and others added 2 commits September 18, 2024 09:03

Merge branch 'googleforgames:main' into main

4075607

lint fixes

c7471aa

lint fix

2ff4eac

0xaravindh marked this pull request as ready for review September 19, 2024 08:54

0xaravindh added 5 commits September 20, 2024 14:17

Merge branch 'googleforgames:main' into main

85e7320

Merge branch 'main' of https://github.com/0xaravindh/agones into gola…

b4787a8

…ngci-lint-version-update

Merge branch 'googleforgames:main' into main

9e70a88

Merge branch 'main' of https://github.com/0xaravindh/agones into gola…

f5e69a8

…ngci-lint-version-update

go-version update

128ed31

peterzhongyi reviewed Sep 23, 2024

View reviewed changes

gen-api-docs shell script update

6a36e50

0xaravindh added 2 commits October 1, 2024 12:58

fix: updated gRPC lint issue and remove deprecated features

68dd3d2

Regenerated Go code for SDK and GRPC services

910deb6

fix: updated beta method in http-api-test

4c8693d

Fix: Update gRPC client connection to use DialContext

4903d49

peterzhongyi mentioned this pull request Oct 1, 2024

Request to become approver of Agone repo #4007

Closed

5 tasks

Merge branch 'main' into golangci-lint-version-update

5dc238d

Merge branch 'main' into golangci-lint-version-update

17896ed

0xaravindh closed this Oct 3, 2024

0xaravindh reopened this Oct 3, 2024

gongmax changed the title ~~Golangci lint version upgrade v1.61.0~~ Upgrade to Golang Version 1.22.6 and Golangci lint version v1.61.0 Oct 3, 2024

gongmax approved these changes Oct 3, 2024

View reviewed changes

cmd/allocator/main.go Show resolved Hide resolved

cmd/allocator/main.go Show resolved Hide resolved

cmd/sdk-server/main.go Show resolved Hide resolved

sdks/swagger/beta.swagger.json Show resolved Hide resolved

gongmax merged commit cd3bc13 into googleforgames:main Oct 3, 2024
6 checks passed

gongmax mentioned this pull request Oct 3, 2024

Upgrade to Golang Version 1.22.6 #3985

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Golang Version 1.22.6 and Golangci lint version v1.61.0 #3988

Upgrade to Golang Version 1.22.6 and Golangci lint version v1.61.0 #3988

0xaravindh commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

agones-bot commented Sep 17, 2024

github-actions bot commented Sep 19, 2024

agones-bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

agones-bot commented Sep 19, 2024

github-actions bot commented Sep 23, 2024

agones-bot commented Sep 23, 2024

peterzhongyi Sep 23, 2024 •

edited

Loading

0xaravindh Sep 24, 2024

github-actions bot commented Sep 27, 2024

agones-bot commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

agones-bot commented Sep 30, 2024

github-actions bot commented Oct 1, 2024

agones-bot commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

agones-bot commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

agones-bot commented Oct 1, 2024

github-actions bot commented Oct 2, 2024

agones-bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

agones-bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

agones-bot commented Oct 3, 2024

gongmax left a comment

Upgrade to Golang Version 1.22.6 and Golangci lint version v1.61.0 #3988

Upgrade to Golang Version 1.22.6 and Golangci lint version v1.61.0 #3988

Conversation

0xaravindh commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

agones-bot commented Sep 17, 2024

github-actions bot commented Sep 19, 2024

agones-bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

agones-bot commented Sep 19, 2024

github-actions bot commented Sep 23, 2024

agones-bot commented Sep 23, 2024

peterzhongyi Sep 23, 2024 • edited Loading

Choose a reason for hiding this comment

0xaravindh Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 27, 2024

agones-bot commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

agones-bot commented Sep 30, 2024

github-actions bot commented Oct 1, 2024

agones-bot commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

agones-bot commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

agones-bot commented Oct 1, 2024

github-actions bot commented Oct 2, 2024

agones-bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

agones-bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

agones-bot commented Oct 3, 2024

gongmax left a comment

Choose a reason for hiding this comment

peterzhongyi Sep 23, 2024 •

edited

Loading