Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds game server template with containerized sdk-client-test #3987

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Sep 16, 2024

What type of PR is this?

/kind feature

What this PR does / Why we need it:

This adds a game server template that includes the sdk-client-test that will be built, pushed, and tagged at the released Agones versions DEV-10 (1.34.0) to DEV-1 (1.43.0). The controller will create gameserver.yaml files for each valid Agones version. In a future PR these game servers will be created and run while installing Agones.

This PR also updates the capitalization to be consistent with Agones' use of CamelCase rather than ALL_CAPS for const values.

This PR gets rid of the go.mod and go.sum files for the upgrade test, and instead makes use of the Docker build process to create the go module when building the image. This will keep the images up to date with the latest versions of dependencies.

Which issue(s) this PR fixes:

Working on: #3795

Special notes for your reviewer:

The sdk-client-test imports agones.dev, so when building the image go.mod can only download released versions of Agones.

@github-actions github-actions bot added kind/feature New features for Agones size/L labels Sep 16, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 1ef7954a-3030-4dc0-a1c0-bf181b408c35

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 73f5b7a0-b291-40a8-aea7-653311017ccc

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 03d6a4ce-1ff9-4173-a895-da1ea3964536

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the testInPlaceUpgrades branch 2 times, most recently from fdbd416 to a4defda Compare September 16, 2024 21:23
@igooch igooch requested a review from gongmax September 16, 2024 21:24
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 3f667124-0cd5-413f-9e9b-7293d6f2d4f8

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: cf9f78a9-f714-4edb-a605-0bbb07b23ac3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3987/head:pr_3987 && git checkout pr_3987
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-983752b

@gongmax gongmax merged commit 89038b6 into googleforgames:main Sep 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants