Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the note at the top of the player tracking docs #3974

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

roberthbailey
Copy link
Member

Make it clearer that it's an alpha feature that will soon be removed.

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it: The docs are currently confusing as they make it sound like player tracking is in beta (which it is not). Also clarify that player tracking will soon be removed.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

clearer that it's an alpha feature that will soon be removed.
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Aug 28, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 3fca8a1b-7a04-4fae-9adc-4bdfbfcb7011

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3974/head:pr_3974 && git checkout pr_3974
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-d1b81cd

@igooch igooch enabled auto-merge (squash) August 29, 2024 22:34
Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 0bf90fcd-d9ac-4977-9a15-a95c72bceb62

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3974/head:pr_3974 && git checkout pr_3974
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-676d5b0

@igooch igooch merged commit 306ecab into googleforgames:main Aug 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants