Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/counter and list defaulting order to ascending #3734

Merged
merged 10 commits into from
Apr 3, 2024
Merged

Feat/counter and list defaulting order to ascending #3734

merged 10 commits into from
Apr 3, 2024

Conversation

lacroixthomas
Copy link
Collaborator

What type of PR is this?
/kind feature

What this PR does / Why we need it:
Defaulting the order from counter and list priorities to Ascending

Which issue(s) this PR fixes:

Closes #3683

Special notes for your reviewer:

@github-actions github-actions bot added kind/feature New features for Agones size/XS labels Mar 27, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0806152d-ac8a-4746-89bd-e4737a88c6f5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2b06ad49-b470-4f58-84dd-dbea7d107321

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f3066fa5-889a-4520-a611-ec1c9b52071b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas lacroixthomas force-pushed the feat/counter-and-list-defaulting-order-to-ascending branch from 999fecb to 6aaa8d0 Compare March 27, 2024 22:45
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 57f9543c-9f2e-4bc3-bdd4-69e3f9957e86

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas lacroixthomas force-pushed the feat/counter-and-list-defaulting-order-to-ascending branch from 59ca618 to 66c939e Compare March 28, 2024 20:13
@lacroixthomas lacroixthomas marked this pull request as ready for review March 28, 2024 20:16
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e49fa991-aa3c-4ddf-b0ce-58588976bf85

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3734/head:pr_3734 && git checkout pr_3734
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-66c939e-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8927e11c-1c21-46de-8f89-946133542dab

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3734/head:pr_3734 && git checkout pr_3734
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-ba64cf6-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 291cc5ae-5216-4b82-9356-5279909ef879

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3734/head:pr_3734 && git checkout pr_3734
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-0e9c587-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e0cbe639-c690-4f61-9dc2-b9d25123ff31

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3734/head:pr_3734 && git checkout pr_3734
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-93b2b7b-amd64

@markmandel
Copy link
Collaborator

@Kalaiselvi84 @lacroixthomas - just noticed you duplicated each other's work 😄

I added some review to #3736 on some tests , primarily on the unit test that needs expanding.

No strong opinions on my end who wraps this one up 😄

@markmandel markmandel mentioned this pull request Apr 1, 2024
Closed
markmandel
markmandel reviewed Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying review across, and adding a few more things - but otherwise looks good 👍🏻

pkg/apis/allocation/v1/gameserverallocation.go
@@ -583,6 +583,12 @@ func (gsa *GameServerAllocation) ApplyDefaults() {
gsa.Spec.Scheduling = apis.Packed
}

for i := range gsa.Spec.Priorities {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests to:

agones/pkg/apis/allocation/v1/gameserverallocation_test.go

Line 31 in a1a1cd9

func TestGameServerAllocationApplyDefaults(t *testing.T) {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also please add a comment here:

agones/pkg/apis/agones/v1/common.go

Line 186 in 986ed9b

// "Ascending" would be smaller available capacity is preferred.

That the default is Ascending.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MR updated following your comments @markmandel 🙂

@github-actions github-actions bot added the size/S label Apr 2, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7d20d9af-dacb-47d7-b936-0869f068daed

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@github-actions github-actions bot added the size/L label Apr 2, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4d2a9cc7-052d-4778-83ca-4f414e25e888

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3734/head:pr_3734 && git checkout pr_3734
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-178beb2-amd64

markmandel
markmandel approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks!

@markmandel markmandel enabled auto-merge (squash) April 2, 2024 23:56
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e4f84174-627c-4eb1-8482-de32d833020b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3734/head:pr_3734 && git checkout pr_3734
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-9dca36a-amd64

@markmandel markmandel merged commit efbc412 into googleforgames:main Apr 3, 2024
4 checks passed
spiceratops referenced this pull request in spiceratops/k8s-gitops May 13, 2024
@spiceratops
feat(helm): update chart agones to 1.40.0 (#746)
129e87f 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [agones](https://agones.dev)
([source](https://togithub.com/googleforgames/agones)) | minor |
`1.39.0` -> `1.40.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>googleforgames/agones (agones)</summary>

###
[`v1.40.0`](https://togithub.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1400-2024-04-23)

[Compare
Source](https://togithub.com/googleforgames/agones/compare/v1.39.0...v1.40.0)

[Full
Changelog](https://togithub.com/googleforgames/agones/compare/v1.39.0...v1.40.0)

**Breaking changes:**

- Counters and Lists: Remove Bool Returns by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3738](https://togithub.com/googleforgames/agones/pull/3738)

**Implemented enhancements:**

- Leader Election in Custom Controller by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3696](https://togithub.com/googleforgames/agones/pull/3696)
- Migrating from generate-groups.sh to kube_codegen.sh by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3722](https://togithub.com/googleforgames/agones/pull/3722)
- Move GKEAutopilotExtendedDurationPods to Alpha in 1.28+ by
[@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3729](https://togithub.com/googleforgames/agones/pull/3729)
- Move DisableResyncOnSDKServer to Beta by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3732](https://togithub.com/googleforgames/agones/pull/3732)
- Counters & Lists landing page and doc improvements by
[@&#8203;markmandel](https://togithub.com/markmandel) in
[https://github.com/googleforgames/agones/pull/3649](https://togithub.com/googleforgames/agones/pull/3649)
- Graduate FleetAllocationOverflow to Stable by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3733](https://togithub.com/googleforgames/agones/pull/3733)
- Adds Counters and Lists to CSharp SDK by
[@&#8203;igooch](https://togithub.com/igooch) in
[https://github.com/googleforgames/agones/pull/3581](https://togithub.com/googleforgames/agones/pull/3581)
- Feat/counter and list defaulting order to ascending by
[@&#8203;lacroixthomas](https://togithub.com/lacroixthomas) in
[https://github.com/googleforgames/agones/pull/3734](https://togithub.com/googleforgames/agones/pull/3734)
- Add handling for StatusAddresses in GameServerStatus for the Unity SDK
by [@&#8203;charlesvien](https://togithub.com/charlesvien) in
[https://github.com/googleforgames/agones/pull/3739](https://togithub.com/googleforgames/agones/pull/3739)
- Feat(gameservers): Shared pod IPs with GameServer Addresses by
[@&#8203;lacroixthomas](https://togithub.com/lacroixthomas) in
[https://github.com/googleforgames/agones/pull/3764](https://togithub.com/googleforgames/agones/pull/3764)
- Be prescriptive about rotating regions when updating Kubernetes
versions by [@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3716](https://togithub.com/googleforgames/agones/pull/3716)
- Fix ensure-e2e-infra-state-bucket by
[@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3719](https://togithub.com/googleforgames/agones/pull/3719)
- Create Performance Cluster 1.28 by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3720](https://togithub.com/googleforgames/agones/pull/3720)
- Optimise GameServer Sub-Controller Queues by
[@&#8203;markmandel](https://togithub.com/markmandel) in
[https://github.com/googleforgames/agones/pull/3781](https://togithub.com/googleforgames/agones/pull/3781)

**Fixed bugs:**

- Counters & Lists: Consolidate `priorities` sorting by
[@&#8203;markmandel](https://togithub.com/markmandel) in
[https://github.com/googleforgames/agones/pull/3690](https://togithub.com/googleforgames/agones/pull/3690)
- Fix(Counter & Lists): Add validation for `priorities` by
[@&#8203;lacroixthomas](https://togithub.com/lacroixthomas) in
[https://github.com/googleforgames/agones/pull/3714](https://togithub.com/googleforgames/agones/pull/3714)
- fix:
[#&#8203;3607](https://togithub.com/googleforgames/agones/issues/3607)
Metrics data loss in K8S controller by
[@&#8203;alvin-7](https://togithub.com/alvin-7) in
[https://github.com/googleforgames/agones/pull/3692](https://togithub.com/googleforgames/agones/pull/3692)
- Deflake GameServerAllocationDuringMultipleAllocationClients by
allowing errors by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3750](https://togithub.com/googleforgames/agones/pull/3750)

**Security fixes:**

- Bump protobufjs from 7.2.4 to 7.2.6 in /sdks/nodejs by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/googleforgames/agones/pull/3755](https://togithub.com/googleforgames/agones/pull/3755)
- Bump golang.org/x/net from 0.19.0 to 0.23.0 by
[@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3793](https://togithub.com/googleforgames/agones/pull/3793)

**Other:**

- Flaky: TestGameServerCreationAfterDeletingOneExtensionsPod by
[@&#8203;markmandel](https://togithub.com/markmandel) in
[https://github.com/googleforgames/agones/pull/3699](https://togithub.com/googleforgames/agones/pull/3699)
- Prep for release v1.40.0 by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3700](https://togithub.com/googleforgames/agones/pull/3700)
- Bumps cpp-simple Image and Refactoring Example Makefiles by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3695](https://togithub.com/googleforgames/agones/pull/3695)
- Upgrade Protobuf to 1.33.0 by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3711](https://togithub.com/googleforgames/agones/pull/3711)
- Modify Script for Makefile Version Updates in Examples Directory by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3712](https://togithub.com/googleforgames/agones/pull/3712)
- Adds simple genai server example documentation to the Agones site by
[@&#8203;igooch](https://togithub.com/igooch) in
[https://github.com/googleforgames/agones/pull/3713](https://togithub.com/googleforgames/agones/pull/3713)
- Update Supported Kubernetes to 1.27, 1.28, 1.29 by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3654](https://togithub.com/googleforgames/agones/pull/3654)
- fix: typo in docs by [@&#8203;qhyun2](https://togithub.com/qhyun2) in
[https://github.com/googleforgames/agones/pull/3723](https://togithub.com/googleforgames/agones/pull/3723)
- Tweak: Setting up the Game Server by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3717](https://togithub.com/googleforgames/agones/pull/3717)
- Docs: gke.md - spelling by
[@&#8203;daniellee](https://togithub.com/daniellee) in
[https://github.com/googleforgames/agones/pull/3740](https://togithub.com/googleforgames/agones/pull/3740)
- Aesthetic rearrangement of cloudbuild.yaml by
[@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3741](https://togithub.com/googleforgames/agones/pull/3741)
- Docs: Make hitting <enter> on connection explicit by
[@&#8203;markmandel](https://togithub.com/markmandel) in
[https://github.com/googleforgames/agones/pull/3743](https://togithub.com/googleforgames/agones/pull/3743)
- CI: Don't check Unreal Link by
[@&#8203;markmandel](https://togithub.com/markmandel) in
[https://github.com/googleforgames/agones/pull/3745](https://togithub.com/googleforgames/agones/pull/3745)
- New recommendation for multi-cluster allocation by
[@&#8203;markmandel](https://togithub.com/markmandel) in
[https://github.com/googleforgames/agones/pull/3744](https://togithub.com/googleforgames/agones/pull/3744)
- Custom Controller Example Page on Agones Website by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3725](https://togithub.com/googleforgames/agones/pull/3725)
- Add Nitrado logo by [@&#8203;towolf](https://togithub.com/towolf) in
[https://github.com/googleforgames/agones/pull/3753](https://togithub.com/googleforgames/agones/pull/3753)
- Remove unnecessary args from e2e-test-cloudbuild by
[@&#8203;zmerlynn](https://togithub.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3754](https://togithub.com/googleforgames/agones/pull/3754)
- Update Allocation from Fleet Documentation by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3761](https://togithub.com/googleforgames/agones/pull/3761)
- Transform Lint Warnings into Errors by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3756](https://togithub.com/googleforgames/agones/pull/3756)
- Update Canary Testing Documentation by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3760](https://togithub.com/googleforgames/agones/pull/3760)
- Supertuxkart Example on Agones Site by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3728](https://togithub.com/googleforgames/agones/pull/3728)
- Xonotic Example on Agones Site by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3742](https://togithub.com/googleforgames/agones/pull/3742)
- nit documentation fix in kind cluster section when building Agones by
[@&#8203;vicentefb](https://togithub.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3770](https://togithub.com/googleforgames/agones/pull/3770)
- Merged steps inside documentation about webhook certificate creation
by [@&#8203;vicentefb](https://togithub.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3768](https://togithub.com/googleforgames/agones/pull/3768)
- Example Images: Increment Tags by
[@&#8203;Kalaiselvi84](https://togithub.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3796](https://togithub.com/googleforgames/agones/pull/3796)
- Update simple game server example documentation by
[@&#8203;vicentefb](https://togithub.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3776](https://togithub.com/googleforgames/agones/pull/3776)

**New Contributors:**

- [@&#8203;lacroixthomas](https://togithub.com/lacroixthomas) made their
first contribution in
[https://github.com/googleforgames/agones/pull/3714](https://togithub.com/googleforgames/agones/pull/3714)
- [@&#8203;daniellee](https://togithub.com/daniellee) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3740](https://togithub.com/googleforgames/agones/pull/3740)
- [@&#8203;charlesvien](https://togithub.com/charlesvien) made their
first contribution in
[https://github.com/googleforgames/agones/pull/3739](https://togithub.com/googleforgames/agones/pull/3739)
- [@&#8203;vicentefb](https://togithub.com/vicentefb) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3770](https://togithub.com/googleforgames/agones/pull/3770)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTYuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM1Ni4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
@lacroixthomas lacroixthomas deleted the feat/counter-and-list-defaulting-order-to-ascending branch May 14, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
kind/feature New features for Agones size/L size/M size/S size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Counter and List Priorities: Default to Ascending.
3 participants
@lacroixthomas @agones-bot @markmandel