Prep for release v1.39.0

[Kalaiselvi84]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3618

Special notes for your reviewer:

[agones-bot]

Build Failed 😱

Build Id: 71ad6283-725f-4dd6-a7fe-d39172a91a8e

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[Kalaiselvi84]

--- FAIL: TestSDKServerRemoveListValue (16.32s)
    --- FAIL: TestSDKServerRemoveListValue/Remove_all_values (1.12s)
        sdkserver_test.go:1626: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:1626
            	Error:      	Not equal: 
            	            	expected: v1.ListStatus{Capacity:100, Values:[]string{}}
            	            	actual  : v1.ListStatus{Capacity:100, Values:[]string{"one"}}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -2,3 +2,4 @@
            	            	  Capacity: (int64) 100,
            	            	- Values: ([]string) {
            	            	+ Values: ([]string) (len=1) {
            	            	+  (string) (len=3) "one"
            	            	  }
            	Test:       	TestSDKServerRemoveListValue/Remove_all_values
        sdkserver_test.go:1636: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:1636
            	Error:      	Not equal: 
            	            	expected: 0
            	            	actual  : 1
            	Test:       	TestSDKServerRemoveListValue/Remove_all_values

Removal of one isn't working as expected🤔

Do we need to modify the order?

agones/pkg/sdkserver/sdkserver_test.go

Lines 1540 to 1543 in 1eb72bc

	{Name: "baz", Value: "three"},
	{Name: "baz", Value: "two"},
	{Name: "baz", Value: "four"},
	{Name: "baz", Value: "one"},

[agones-bot]

Build Failed 😱

Build Id: 45d6e5df-7d2f-4c14-9058-1ad95aa0af1f

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

I think that's a flaky test - @igooch I thought this one was fixed, or am I wrong?

#3620 (comment)

I'll kick the build off again.

[agones-bot]

Build Failed 😱

Build Id: 17c57561-5986-4f62-9a39-cff4dccd9e0f

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

That's a new flake in the unit tests...

Trace[1995358745]: [29.979963541s] [29.979963541s] END
panic: test timed out after 10m0s
running tests:
	TestControllerSyncGameServer (9m59s)
	TestControllerSyncGameServer/Creating_a_new_GameServer (9m59s)

goroutine 3403 [running]:
testing.(*M).startAlarm.func1()
	/usr/local/go/src/testing/testing.go:2259 +0x259
created by time.goFunc
	/usr/local/go/src/time/sleep.go:176 +0x45

goroutine 1 [chan receive, 9 minutes]:
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1561 +0x9ac
testing.tRunner(0xc000504d00, 0xc0005fdaf8)
	/usr/local/go/src/testing/testing.go:1601 +0x295
testing.runTests(0xc000305220?, {0x3d60f80, 0x23, 0x23}, {0x80?, 0xc0005fdb68?, 0x3d78e80?})
	/usr/local/go/src/testing/testing.go:2052 +0x8ae
testing.(*M).Run(0xc000305220)
	/usr/local/go/src/testing/testing.go:1925 +0xcd8
main.main()
	_testmain.go:115 +0x2be

goroutine 28 [chan receive, 9 minutes]:
testing.(*T).Run(0xc000505040, {0x2aa5067, 0x19}, 0x2b8b120)
	/usr/local/go/src/testing/testing.go:1649 +0x871
agones.dev/agones/pkg/gameservers.TestControllerSyncGameServer(0x0?)
	/go/src/agones.dev/agones/pkg/gameservers/controller_test.go:62 +0x45
testing.tRunner(0xc000505040, 0x2b8aed0)
	/usr/local/go/src/testing/testing.go:1595 +0x262
created by testing.(*T).Run in goroutine 1
	/usr/local/go/src/testing/testing.go:1648 +0x846

[agones-bot]

Build Succeeded 👏

Build Id: 55cbde1e-1458-4e1e-b4dd-3671ad84f3ef

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.39.0-dev-2814a6b-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.39.0-dev-2814a6b-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.39.0-dev-2814a6b-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.39.0-dev-2814a6b-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.39.0-dev-2814a6b-amd64
• Linux C++ SDK (build): agonessdk-1.39.0-dev-2814a6b-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.39.0-dev-2814a6b-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://2814a6b-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3620/head:pr_3620 && git checkout pr_3620
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-2814a6b-amd64