Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Golang Version to 1.21.6 #3602

Merged
merged 7 commits into from
Jan 26, 2024
Merged

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3601

Special notes for your reviewer:

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Jan 19, 2024
@Kalaiselvi84
Copy link
Contributor Author

The make cloud-build command has succeeded for all the necessary example images(autoscaler-webhook, crd-client, supertuxkart, xonotic, and simple-game-server) in my project. The files go.mod and go.sum have been updated only for the autoscaler-webhook image.

Please confirm if this looks good to you to push these new images to production. I will commit the remaining file updates in this PR after the push.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 84d3ec9f-3e36-464b-98f2-15ad3facefff

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3602/head:pr_3602 && git checkout pr_3602
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-0b33fbc-amd64

@markmandel
Copy link
Member

LGTM! @igooch you got anything?

@igooch
Copy link
Collaborator

igooch commented Jan 19, 2024

We should update the mod files as well for the main repo and the examples ~/agones$ go mod edit -go=1.21. You might need to update your machine and IDE Go versions to 1.21 in order to run go mod tidy after the change to 1.21 in the go.mod files.

@markmandel
Copy link
Member

We should update the mod files as well for the main repo and the examples ~/agones$ go mod edit -go=1.21. You might need to update your machine and IDE Go versions to 1.21 in order to run go mod tidy after the change to 1.21 in the go.mod files.

Good call 👍🏻

@Kalaiselvi84
Copy link
Contributor Author

Installed the Go v1.21.6. and updated the mod files using go mod edit -go=1.21 and go mod tidy.

@igooch
Copy link
Collaborator

igooch commented Jan 20, 2024

We should update for the go.mod files in the examples/ directories as well.

@Kalaiselvi84
Copy link
Contributor Author

We should update for the go.mod files in the examples/ directories as well.

I used the same commands but mod files haven't modified. Am I missing anything?

~/Desktop/agones/examples$ go mod edit -go=1.21
~/Desktop/agones/examples$ go mod tidy

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2ba7dc08-07ff-489a-bb33-ccac205f4e44

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3602/head:pr_3602 && git checkout pr_3602
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-207c0d7-amd64

@Kalaiselvi84
Copy link
Contributor Author

Following commands help to update the subdirectories of mod and sum files:

agones/examples$ find . -name 'go.mod' -execdir go mod edit -go=1.21 ;
agones/examples$ find . -name 'go.mod' -execdir go mod tidy ;

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5a70d1aa-46b2-42e0-8fad-040d9e655693

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch
Copy link
Collaborator

igooch commented Jan 22, 2024

Test failure will likely be fixed with #3603.

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. @igooch anything else on your end?

examples/autoscaler-webhook/Makefile Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0206cbc8-41bf-4cd5-9315-162aa9fe885a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3602/head:pr_3602 && git checkout pr_3602
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-1d65873-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f9750657-b6a6-4e69-a586-dd6573605f92

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3602/head:pr_3602 && git checkout pr_3602
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-71a22b9-amd64

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igooch igooch merged commit f8083af into googleforgames:main Jan 26, 2024
4 checks passed
@Kalaiselvi84 Kalaiselvi84 deleted the go1.21.x branch March 15, 2024 01:02
@igooch igooch mentioned this pull request Jul 3, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/M size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Golang Version to go1.20.12
4 participants