Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Counters and Lists REST API Conformance Tests #3546

Merged
merged 5 commits into from
Dec 16, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Dec 15, 2023

What type of PR is this?

/kind feature

What this PR does / Why we need it:

  • Adds Counters and Lists REST API Conformance Tests.
  • Updates SDK server UpdateCounter to handle multiple changes in one request as the REST API can request to change the capacity, count, and countdiff all in one request. (The REST API client is generated directly from the alpha.proto and has the methods GetCounter, UpdateCounter, GetList, UpdateList, AddListValue and RemoveListValue which are different from the client methods in the Arbitrary Counts and Lists for GameServers, SDKs and Allocation #2716 that the Go SDK uses and other language SDKs will use.)
  • Updates the SDK Server to follow the same updateCounter sequence as the local SDK server of first updating the setcapacity, then setcount, then countdiff.
  • Fixes a bug in the local SDK server to properly update the setcount.
  • Refactors Player Tracking REST API Conformance tests into a separate method to reduce cyclomatic complexity.

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

…quest

as the REST API can request to change the capacity, count, and countdiff all in one request.

Also updates the SDK Server to follow the same change update pattern as the local SDK server of first updating the capacity, then setcount, then countdiff.

Fixes a bug in the local SDK server to properly update the setcount.
@github-actions github-actions bot added kind/feature New features for Agones size/M labels Dec 15, 2023
@zmerlynn zmerlynn enabled auto-merge (squash) December 15, 2023 23:55
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 221552aa-bb48-4434-a403-12d4598e8070

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3546/head:pr_3546 && git checkout pr_3546
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-5171a59-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4093cbe4-4ce8-4245-a704-114f6ca49a04

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f8c60d1d-fed1-4f81-a576-c9ab2cb7227c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3546/head:pr_3546 && git checkout pr_3546
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-a710c98-amd64

@zmerlynn zmerlynn merged commit 6395907 into googleforgames:main Dec 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants