-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds gameserverallocation e2e tests for Lists #3516
Adds gameserverallocation e2e tests for Lists #3516
Conversation
Build Succeeded 👏 Build Id: 4908f353-fdce-4836-8683-69ebb9b51574 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just one question, then I think good to merge.
753508f
to
1767454
Compare
Build Succeeded 👏 Build Id: 55c5570a-3d2f-420c-99ef-b72e188fb1ff The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: igooch, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: 6f676fb9-2fd3-4188-95c3-a78266221c73 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Adds GameServerAllocation e2e tests for Lists.
Changes GameServerAllocation action to truncate the List to Capacity if only the capacity is changed, to be consistent with the behavior with Counters.
Which issue(s) this PR fixes:
Working on #2716
Special notes for your reviewer: