Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds gameserverallocation e2e tests for Lists #3516

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Nov 20, 2023

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Adds GameServerAllocation e2e tests for Lists.

Changes GameServerAllocation action to truncate the List to Capacity if only the capacity is changed, to be consistent with the behavior with Counters.

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@github-actions github-actions bot added the kind/feature New features for Agones label Nov 20, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4908f353-fdce-4836-8683-69ebb9b51574

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3516/head:pr_3516 && git checkout pr_3516
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-753508f-amd64

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one question, then I think good to merge.

test/e2e/gameserverallocation_test.go Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 55c5570a-3d2f-420c-99ef-b72e188fb1ff

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3516/head:pr_3516 && git checkout pr_3516
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-1767454-amd64

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot removed the lgtm label Nov 21, 2023
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6f676fb9-2fd3-4188-95c3-a78266221c73

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3516/head:pr_3516 && git checkout pr_3516
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-429441c-amd64

@markmandel markmandel merged commit f5bdb4d into googleforgames:main Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/feature New features for Agones size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants