Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds List SDK methods to simple-game-server #3500

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Nov 10, 2023

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Update Go simple-game-server to have commands for List SDK methods necessary for List end to end tests.

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

We'll also need to run make cloud-build to build and push the new example image, and bump references to the image tag.

@github-actions github-actions bot added the kind/feature New features for Agones label Nov 10, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: caaf4884-346f-4baf-84ce-1d13e73f44fd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3500/head:pr_3500 && git checkout pr_3500
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-fc6afc5-amd64

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest updating the version in the Makefile in this dir, and the yaml files, to (a) get that chunk of work done and (b) once this is merged into main, we can push to prod from the main branch.

examples/simple-game-server/README.md Show resolved Hide resolved
examples/simple-game-server/main.go Show resolved Hide resolved
@igooch
Copy link
Collaborator Author

igooch commented Nov 10, 2023

I was going to suggest updating the version in the Makefile in this dir, and the yaml files, to (a) get that chunk of work done and (b) once this is merged into main, we can push to prod from the main branch.

Not sure what you mean here?

@markmandel
Copy link
Member

I was going to suggest updating the version in the Makefile in this dir, and the yaml files, to (a) get that chunk of work done and (b) once this is merged into main, we can push to prod from the main branch.

Not sure what you mean here?

Increment the value here:

server_tag := simple-game-server:0.21
else
server_tag := $(REPOSITORY)/simple-game-server:0.21

As well as updating the yaml files as well, such as:

image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.21

And gameserver.yaml,. fleet-distributed.yaml, dev-gameserver.yaml etc etc

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a61c7e20-cc24-472d-8124-018ba4c8f69b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3500/head:pr_3500 && git checkout pr_3500
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-4ccb92c-amd64

@markmandel markmandel merged commit 9e7d596 into googleforgames:main Nov 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants