-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds List SDK methods to simple-game-server #3500
Adds List SDK methods to simple-game-server #3500
Conversation
Build Succeeded 👏 Build Id: caaf4884-346f-4baf-84ce-1d13e73f44fd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to suggest updating the version in the Makefile in this dir, and the yaml files, to (a) get that chunk of work done and (b) once this is merged into main
, we can push to prod from the main
branch.
Not sure what you mean here? |
Increment the value here: agones/examples/simple-game-server/Makefile Lines 42 to 44 in 9e4400b
As well as updating the yaml files as well, such as:
And gameserver.yaml,. |
ad5b95b
to
4ccb92c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: igooch, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: a61c7e20-cc24-472d-8124-018ba4c8f69b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Update Go simple-game-server to have commands for List SDK methods necessary for List end to end tests.
Which issue(s) this PR fixes:
Working on #2716
Special notes for your reviewer:
We'll also need to run
make cloud-build
to build and push the new example image, and bump references to the image tag.