Updates to gRPC generation #3483
Conversation
Some cleanup post the last series of gRPC updates and changes for future gRPC updates. * Cleanup the instructions for better clarity and operational ordering. * Fix for allocation gRPC generation to reuse the gRPC version include in the build container image rather than unnecessarily build its own.
markmandel
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Kalaiselvi84 do want to check with you if any of the changes to the release process need improvement in any way - let me know! |
Nope! We are good with our release process steps.👍🏻 |
|
New changes are detected. LGTM label has been removed. |
| and `gRPC_GIT_TAG` [here](https://github.com/googleforgames/agones/blob/main/sdks/cpp/cmake/prerequisites.cmake) | ||
| - [ ] Regenerate all client sdks: [make gen-all-sdk-grpc](https://github.com/googleforgames/agones/blob/main/build/README.md#make-gen-all-sdk-grpc) | ||
| This can take an hour or so, as the above changes force a rebuild. Plan your day accordingly 😃. | ||
| - [ ] Regenerate allocated API endpoints: [make gen-allocation-grpc](https://github.com/googleforgames/agones/blob/main/build/README.md#make-gen-allocation-grpc) |
There was a problem hiding this comment.
First, we need to run make gen-allocation-grpc, followed by the make gen-all-sdk-grpc target🤔
Do we need also mention to run make build target followed by the sdk.mk file update and rebuilding all the sdk docker images if it is required?
There was a problem hiding this comment.
First, we need to run
make gen-allocation-grpc, followed by the make gen-all-sdk-grpc target🤔
No I deliberately switched the order to make make gen-all-sdk-grpc run first. It's the more important step of the two.
Do we need also mention to run
make buildtarget followed by the sdk.mk file update and rebuilding all the sdk docker images if it is required?
There's no need to run make build, everything that needs to get rebuilt gets rebuilt automatically (the sdk and allocation grpc build images are actually separate from the main Go/Agones build image).
There was a problem hiding this comment.
I am super confused, but if these steps work for the Kubernetes upgrade, then it's fine.😅
|
Build Succeeded 👏 Build Id: 82527832-1368-40a1-9c3a-1038d4b55317 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Some cleanup post the last series of gRPC updates and changes for future gRPC updates.
What type of PR is this?
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: