Cmake: Ensure find_dependency is on rebuild #3477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not 100% sure why, but on build, the `find_dependency` function is available, but on subsequent rebuilds, it is not. This ensure the macro is always available, and unblocking CI.
markmandel
added
the
area/tests
markmandel
requested review from
zmerlynn and
gongmax
and removed request for
cyriltovena and
EricFortin
|
Build Succeeded 👏 Build Id: 429bfe45-8319-469b-b839-3f4dfb9971d4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
gongmax
approved these changes
Nov 1, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Not 100% sure why, but on build, the
find_dependencyfunction is available, but on subsequent rebuilds, it is not.This ensure the macro is always available, and unblocking CI.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A