Update Nodejs Apt Repository to latest #3434

Kalaiselvi84 · 2023-10-17T04:54:59Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Work on #3430

Special notes for your reviewer:

agones-bot · 2023-10-17T06:22:41Z

Build Succeeded 👏

Build Id: 641a9e2a-130a-43a8-9b36-997f8e6aae55

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://4c2084b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3434/head:pr_3434 && git checkout pr_3434
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-4c2084b-amd64

steven-supersolid · 2023-10-17T16:44:04Z

build/build-image/Dockerfile

-RUN echo "deb [signed-by=$KEYRING] https://deb.nodesource.com/$VERSION $DISTRO main" | tee /etc/apt/sources.list.d/nodesource.list
-RUN echo "deb-src [signed-by=$KEYRING] https://deb.nodesource.com/$VERSION $DISTRO main" | tee -a /etc/apt/sources.list.d/nodesource.list
+# Create deb repository for a specific Node major version
+ARG NODE_MAJOR=10


My bad, I typed 10 instead of 18 in the issue
But I think 20 would be ok too

steven-supersolid

Looks good as long as tests pass

agones-bot · 2023-10-17T16:48:04Z

Build Failed 😱

Build Id: 911102f8-5fa5-46db-a49c-89cc94715ea4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-10-17T17:00:24Z

I think we'll need to update both this and agones/build/build-sdk-images/node/Dockerfile at the same time - since in the above is where the failure happens.

Kalaiselvi84 · 2023-10-17T17:01:08Z

Looks good as long as tests pass

Can you please check this log and confirm if everything looks good? https://gist.github.com/Kalaiselvi84/65cf8131f5f3062028ae03254ed1d83d

Kalaiselvi84 · 2023-10-17T17:07:51Z

I think we'll need to update both this and agones/build/build-sdk-images/node/Dockerfile at the same time - since in the above is where the failure happens.

I've updated the build-sdk-images/node/Dockerfile

agones-bot · 2023-10-17T17:14:33Z

Build Failed 😱

Build Id: 9f9ec9b3-0095-47f5-a3fd-c0d61285b52d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-10-17T17:14:37Z

🤞🏻

markmandel · 2023-10-17T17:17:34Z

Aarg, we'll need to do agones/build/build-sdk-images/restapi/Dockerfile as well (since it's all used in the same test).

I'm still not 100% sure we need nodejs there? But for right now, let's replace it so we can unstick CI, and we can try again later in removing the nodejs dependency from the image at a later date.

Kalaiselvi84 · 2023-10-17T17:24:28Z

Aarg, we'll need to do agones/build/build-sdk-images/restapi/Dockerfile as well (since it's all used in the same test).

I'm still not 100% sure we need nodejs there? But for right now, let's replace it so we can unstick CI, and we can try again later in removing the nodejs dependency from the image at a later date.

Done!
Shall we update the agones/examples/nodejs-simple/Dockerfile? It's the only file pending😅

markmandel · 2023-10-17T17:27:13Z

Shall we update the agones/examples/nodejs-simple/Dockerfile? It's the only file pending😅

We can, but we'll need to bump the example image number and eventually push a new image at that time as well, so it could be handled seperately.

markmandel · 2023-10-17T18:05:56Z

Just watching the build - looks like 11: test-gen-all-sdk-grpc passed. I think we have a winner here.

agones-bot · 2023-10-17T18:26:52Z

Build Succeeded 👏

Build Id: 09e600fb-33c3-46fe-9b9d-d9eb49460e85

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://e032097-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3434/head:pr_3434 && git checkout pr_3434
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-e032097-amd64

Kalaiselvi84 · 2023-10-17T18:31:39Z

Silly question: Are we good to merge, or do we need to test it?

markmandel · 2023-10-17T18:32:55Z

This was the test 😄 - feel free to move this to "ready for review" 👍🏻

google-oss-prow · 2023-10-17T18:36:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2023-10-17T18:40:51Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-10-17T20:09:39Z

Build Succeeded 👏

Build Id: 57be9e12-30a6-4452-a31b-99c1e008ffdc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://d9e47da-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3434/head:pr_3434 && git checkout pr_3434
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-d9e47da-amd64

Update Nodejs Apt Repository to latest

4c2084b

Kalaiselvi84 requested a review from markmandel October 17, 2023 04:54

google-oss-prow bot added the do-not-merge/work-in-progress label Oct 17, 2023

google-oss-prow bot requested review from aLekSer and EricFortin October 17, 2023 04:55

google-oss-prow bot added the size/S label Oct 17, 2023

github-actions bot added the kind/other label Oct 17, 2023

Kalaiselvi84 added 2 commits October 17, 2023 16:05

Removed deprecated Nodejs repo

d30fc41

NodeJS with LTS 10

eaaaded

Kalaiselvi84 requested a review from steven-supersolid October 17, 2023 16:40

steven-supersolid reviewed Oct 17, 2023

View reviewed changes

NodeJS with LTS 20

010a374

steven-supersolid approved these changes Oct 17, 2023

View reviewed changes

google-oss-prow bot assigned steven-supersolid Oct 17, 2023

google-oss-prow bot added the lgtm label Oct 17, 2023

Update build/build-sdk-images/node/Dockerfile

9e0fca2

google-oss-prow bot added size/M and removed lgtm size/S labels Oct 17, 2023

build/build-sdk-images/restapi/Dockerfile

e032097

markmandel approved these changes Oct 17, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Oct 17, 2023

google-oss-prow bot added the lgtm label Oct 17, 2023

google-oss-prow bot added the approved label Oct 17, 2023

markmandel mentioned this pull request Oct 17, 2023

[Build Tools] Update Nodejs Apt Repository to latest #3430

Closed

4 tasks

Merge branch 'main' into build-image/Dockerfile

d9e47da

google-oss-prow bot removed the lgtm label Oct 17, 2023

Kalaiselvi84 marked this pull request as ready for review October 17, 2023 18:41

google-oss-prow bot removed the do-not-merge/work-in-progress label Oct 17, 2023

google-oss-prow bot requested review from cyriltovena and roberthbailey October 17, 2023 18:41

markmandel enabled auto-merge (squash) October 17, 2023 18:41

markmandel merged commit 1caefe0 into googleforgames:main Oct 17, 2023
3 checks passed

Kalaiselvi84 added kind/cleanup Refactoring code, fixing up documentation, etc and removed kind/other labels Nov 2, 2023

Kalaiselvi84 deleted the build-image/Dockerfile branch March 15, 2024 01:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Nodejs Apt Repository to latest #3434

Update Nodejs Apt Repository to latest #3434

Kalaiselvi84 commented Oct 17, 2023 •

edited

Loading

agones-bot commented Oct 17, 2023

steven-supersolid Oct 17, 2023

steven-supersolid left a comment

agones-bot commented Oct 17, 2023

markmandel commented Oct 17, 2023

Kalaiselvi84 commented Oct 17, 2023

Kalaiselvi84 commented Oct 17, 2023 •

edited

Loading

agones-bot commented Oct 17, 2023

markmandel commented Oct 17, 2023

markmandel commented Oct 17, 2023 •

edited

Loading

Kalaiselvi84 commented Oct 17, 2023 •

edited

Loading

markmandel commented Oct 17, 2023

markmandel commented Oct 17, 2023

agones-bot commented Oct 17, 2023

Kalaiselvi84 commented Oct 17, 2023

markmandel commented Oct 17, 2023

google-oss-prow bot commented Oct 17, 2023

google-oss-prow bot commented Oct 17, 2023

agones-bot commented Oct 17, 2023

Update Nodejs Apt Repository to latest #3434

Update Nodejs Apt Repository to latest #3434

Conversation

Kalaiselvi84 commented Oct 17, 2023 • edited Loading

agones-bot commented Oct 17, 2023

steven-supersolid Oct 17, 2023

Choose a reason for hiding this comment

steven-supersolid left a comment

Choose a reason for hiding this comment

agones-bot commented Oct 17, 2023

markmandel commented Oct 17, 2023

Kalaiselvi84 commented Oct 17, 2023

Kalaiselvi84 commented Oct 17, 2023 • edited Loading

agones-bot commented Oct 17, 2023

markmandel commented Oct 17, 2023

markmandel commented Oct 17, 2023 • edited Loading

Kalaiselvi84 commented Oct 17, 2023 • edited Loading

markmandel commented Oct 17, 2023

markmandel commented Oct 17, 2023

agones-bot commented Oct 17, 2023

Kalaiselvi84 commented Oct 17, 2023

markmandel commented Oct 17, 2023

google-oss-prow bot commented Oct 17, 2023

google-oss-prow bot commented Oct 17, 2023

agones-bot commented Oct 17, 2023

Kalaiselvi84 commented Oct 17, 2023 •

edited

Loading

Kalaiselvi84 commented Oct 17, 2023 •

edited

Loading

markmandel commented Oct 17, 2023 •

edited

Loading

Kalaiselvi84 commented Oct 17, 2023 •

edited

Loading