Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docsy Upgrade #3417

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Docsy Upgrade #3417

merged 3 commits into from
Oct 12, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

@Kalaiselvi84 Kalaiselvi84 commented Oct 10, 2023

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3346

Special notes for your reviewer:

@Kalaiselvi84
Copy link
Contributor Author

In this PR, I haven't made any changes to the site-static target to update the postcss-cli and autoprefixer to their latest versions. While the pre-build-release target is successfully passing with the recent versions, the 'site-static' and 'hugo-test' targets are failing when using the latest versions.

Here's the log for site-static - https://gist.github.com/Kalaiselvi84/91c62eff8f8d7fb9167b759253c252b6

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3dacd8cb-7a73-4c4f-819e-24ff58f0ca82

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3417/head:pr_3417 && git checkout pr_3417
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-ff692cf-amd64

@Kalaiselvi84
Copy link
Contributor Author

@markmandel, Just checking in - did you get a chance to peek at the preview of this PR? If it's still on your to-do list, no rush, just a gentle reminder.. If you've already had a look, any feedback or pending items?

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just reviewing this! Looks great, let's do it!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a1bd8413-b7ae-4342-8211-f8627a8b0fed

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3417/head:pr_3417 && git checkout pr_3417
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-1bfa47e-amd64

@markmandel markmandel merged commit cd1f39b into googleforgames:main Oct 12, 2023
3 checks passed
This was referenced Oct 12, 2023
@Kalaiselvi84 Kalaiselvi84 added kind/cleanup Refactoring code, fixing up documentation, etc and removed kind/other labels Nov 2, 2023
@Kalaiselvi84 Kalaiselvi84 deleted the docs branch March 15, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Hugo and Docsy
3 participants