-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds GameServer e2e tests for Counters #3381
Adds GameServer e2e tests for Counters #3381
Conversation
Build Succeeded 👏 Build Id: 5660dd3b-b453-40cc-94ce-cbfcb3a799b9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit on error checking, but otherwise, LGTM!
Build Succeeded 👏 Build Id: fa1a2402-b084-431f-a015-bb2d0d35b04f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
cf4a328
to
0e003d7
Compare
Build Succeeded 👏 Build Id: 0937ea26-f434-4105-bf8f-d3a36e34894f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy as!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: igooch, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Adds GameServer e2e tests for Counters
Which issue(s) this PR fixes:
Working on #2716
Special notes for your reviewer: