-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Allocation Overflow Documentation #3368
Conversation
Build Succeeded 👏 Build Id: 59cd6021-0c32-4adb-bc51-7c06bb276233 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Looks good! Can we also add a line to https://agones.dev/site/docs/guides/fleet-updates/#notifying-gameservers-on-fleet-updatedownscale specifying:
I think the best place for this is here: I think that should cover things. |
Build Succeeded 👏 Build Id: b29ee068-ffe5-4412-9069-3180c53ee936 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there 👍🏻
Build Succeeded 👏 Build Id: d93bb547-f674-4920-afbe-2cb1bd4aacd0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
@@ -147,6 +147,8 @@ This provides two useful capabilities: | |||
2. This can also be used to proactively update `GameServer` labels, to effect change in allocation strategy - such as | |||
preferring the newer `GameServers` when allocating, but falling back to the older version if there aren't enough | |||
of the new ones yet spun up. | |||
|
|||
The labels and/or annotations are applied to `GameServers` in a `Fleet` in the order designated by their configured [Fleet scheduling]({{< ref "/docs/Advanced/scheduling-and-autoscaling#fleet-scheduling">}}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The labels and/or annotations are applied to `GameServers` in a `Fleet` in the order designated by their configured [Fleet scheduling]({{< ref "/docs/Advanced/scheduling-and-autoscaling#fleet-scheduling">}}) | |
The labels and/or annotations are applied to `GameServers` in a `Fleet` in the order designated by their configured [Fleet scheduling]({{< ref "/docs/Advanced/scheduling-and-autoscaling#fleet-scheduling">}}). |
Small final nit!
Build Succeeded 👏 Build Id: 5f56c46c-0d6d-4d4b-8855-be5a4feb70da The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kalaiselvi84, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: 78344229-721c-4acb-9f6f-9384a3ffe8d5 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
Fix documentation bugs in allocationOverflow documentation.
Which issue(s) this PR fixes:
Closes #3361
Special notes for your reviewer: