Do not refresh cache if no update #3343
Conversation
| @@ -70,6 +70,9 @@ func NewAllocationCache(informer informerv1.GameServerInformer, counter *gameser | |||
| if !ok { | |||
| return | |||
| } | |||
| if oldGs.ObjectMeta.ResourceVersion == newGs.ObjectMeta.ResourceVersion { | |||
There was a problem hiding this comment.
I like it! Good find!
Worth a unit test, or nah?
There was a problem hiding this comment.
Oh, I will add an unit test.
|
Build Failed 😱 Build Id: 97bb2b2c-958f-4cbe-94d7-5f69b470d551 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: 4c1dea12-c298-4426-8d75-2c314ea4ced0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
gongmax
requested review from
markmandel and
zmerlynn
and removed request for
cyriltovena and
aLekSer
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: 8c0de90a-dae6-4aa0-93e4-a38a93f554cd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind bug
What this PR does / Why we need it:
In the UpdateFunc, check whether there are actual change for the GameServer by checking the resourceVersion, and skip the allocation cache refresh for the GameServer if so. This prevents the race condition where a GS is Allocated and removed from the cache but the UpdateFunc adds it back with a stale state.
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: