refactor: apihook ValidateGameServerSpec and ValidateScheduling use field.ErrorList

[aimuz]

Signed-off-by: aimuz mr.imuz@gmail.com

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind breaking

What this PR does / Why we need it:

#3239

related task

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

[aimuz]

/assign markmandel
/assign zmerlynn

[agones-bot]

Build Failed 😱

Build Id: 6f93d496-c17b-4e85-b0a9-0d83c214177b

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: d24238bd-31dd-424c-bcf0-0ecfb165320f

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: 8e60d10f-370b-4ffa-aa9a-bde4ae377150

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: a2feb552-804f-4b7e-a752-7923abea5b28

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: 0349c2b7-652a-4908-b5c8-09896b80625a

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.34.0-dev-19fa750-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.34.0-dev-19fa750-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.34.0-dev-19fa750-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.34.0-dev-19fa750-amd64
• Linux C++ SDK (build): agonessdk-1.34.0-dev-19fa750-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.34.0-dev-19fa750-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://19fa750-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3255/head:pr_3255 && git checkout pr_3255
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-19fa750-amd64

[zmerlynn]

This honestly looks pretty good to me. @markmandel ?

[markmandel]

LGTM too!

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aimuz, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[google-oss-prow]

New changes are detected. LGTM label has been removed.

[agones-bot]

Build Succeeded 👏

Build Id: 73dc44ec-d101-4b2f-8501-a9ba6598a143

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.34.0-dev-66b115f-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.34.0-dev-66b115f-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.34.0-dev-66b115f-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.34.0-dev-66b115f-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.34.0-dev-66b115f-amd64
• Linux C++ SDK (build): agonessdk-1.34.0-dev-66b115f-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.34.0-dev-66b115f-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://66b115f-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3255/head:pr_3255 && git checkout pr_3255
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-66b115f-amd64