Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maintenance exclusion to prevent auto-upgrade, add 1.27 test clusters #3253

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented Jul 10, 2023

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
The Kubernetes version of the test cluster should stay at the same minor version as when it was created. Use maintenance exclusion to prevent auto-upgrade.

Also include the 1.27 test clusters in this PR.
The clusters have already been updated: https://pantheon.corp.google.com/kubernetes/list/overview?e=13803378&hl=en&jsmode=o&mods=logs_tg_prod&project=agones-images
Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@github-actions github-actions bot added the kind/bug These are bugs. label Jul 10, 2023
@gongmax gongmax requested review from zmerlynn and Kalaiselvi84 and removed request for aLekSer and roberthbailey July 10, 2023 18:01
@gongmax gongmax marked this pull request as ready for review July 10, 2023 18:01
@zmerlynn
Copy link
Collaborator

Hmm, can we look at what it would look like to do an exclusion window instead, since it's what we now recommend in the docs?

@gongmax
Copy link
Collaborator Author

gongmax commented Jul 10, 2023

Hmm, can we look at what it would look like to do an exclusion window instead, since it's what we now recommend in the docs?

I'm a little hesitate to go down that way. It introduces extra maintenance burden to update the exclusion policy before it expires. Not sure whether it worth.

@zmerlynn
Copy link
Collaborator

I'm a little hesitate to go down that way. It introduces extra maintenance burden to update the exclusion policy before it expires. Not sure whether it worth.

In theory you should be able to exclude minor version upgrades for 180 days - if terraform supports them, we could just have the window updated to whenever terraform runs, and we'll be updating every 180 days anyways, right?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 779227ce-0990-4338-ba3d-387c808a5b92

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3253/head:pr_3253 && git checkout pr_3253
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-70c5592-amd64

@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Jul 13, 2023
@gongmax gongmax changed the title Do not use channel for standard cluster to prevent auto-upgrade Use maintenance exclusion to prevent auto-upgrade, add 1.27 test clusters Jul 13, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d72c13de-1ca5-44f4-9205-0d432b95bc92

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3253/head:pr_3253 && git checkout pr_3253
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-4652167-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign roberthbailey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot removed the lgtm label Jul 14, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: deca16c8-c912-4db2-a2bc-7dbea4054b17

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3253/head:pr_3253 && git checkout pr_3253
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-a05df23-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9390690e-0d20-46e7-9a79-7f73c4c5e1c8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f4ef0292-7da7-4a6f-985c-c6f55cc7a946

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5b2b837f-f69b-4c84-b044-38a9aa7cb2fb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3253/head:pr_3253 && git checkout pr_3253
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-9b3871d-amd64

@gongmax gongmax merged commit 98bafb0 into googleforgames:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants