Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goclient request dashboard and add allocator to the drill down; Change goclient workqueue dashboard y axis unit #3240

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented Jun 29, 2023

… axis

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

  1. Fix the issue that the go-client request dashboard doesn't show up by changing the datasource to null. I don't know the root cause, it just works.
  2. Add allocator to the go-client request dashboard drill down
  3. Change the y axis unit of the go-client workqueue from duration to second. This is because duration cannot show any value less than 1 second, which makes the metrics hard to read.

Which issue(s) this PR fixes:

Closes #3218

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 53cc4640-5cc3-44d7-ac66-4fd86685126d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3240/head:pr_3240 && git checkout pr_3240
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-643429d-amd64

@gongmax gongmax changed the title Fix goclient request dashboard and add allocator to the drill down; Change goclient workqueue dashboard y axis unit; Fix goclient request dashboard and add allocator to the drill down; Change goclient workqueue dashboard y axis unit Jun 29, 2023
@gongmax gongmax marked this pull request as ready for review June 29, 2023 16:35
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8fb1ea81-77b0-4c66-8ccd-f665d9f9870a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3240/head:pr_3240 && git checkout pr_3240
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-a687c7e-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel enabled auto-merge (squash) June 29, 2023 19:59
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 29, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dc90c9ca-17b4-4d5c-aa9f-f3dd10be702e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3240/head:pr_3240 && git checkout pr_3240
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-470a7e8-amd64

@markmandel markmandel merged commit 05ab9ca into googleforgames:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/feature New features for Agones size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agones-controller-go-client-requests dashboard missing
3 participants