-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fix for one issue with TestFleetRecreateGameServers test #3163
Conversation
Build Succeeded 👏 Build Id: de35bfaa-c503-4385-856b-c42ea81e4d7a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch for this corner case!
Update value.yaml for
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chiayi, gongmax, zmerlynn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Failed 😱 Build Id: 98f7664c-9438-4304-9c81-da95a6d70e7c To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: b0b97bdc-5a97-4607-b520-9e459aca9a70 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
…mes#3163) If game servers are in `Shutdown`, ignore them.
Add fix for one issue with TestFleetRecreateGameServers test
What type of PR is this?
/kind bug
What this PR does / Why we need it:
The test
TestFleetRecreateGameServers
fails due to an issue with the number of gameservers it receives, instead of having 10, it gets 11 gameservers. And one of the gameservers would be inShutdown
state.Which issue(s) this PR fixes:
TestFleetRecreateGameServers flakiness
Special notes for your reviewer: