Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocation.proto Updates for Counts and Lists #3150

Merged
merged 3 commits into from
May 17, 2023
Merged

Allocation.proto Updates for Counts and Lists #3150

merged 3 commits into from
May 17, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented May 12, 2023

What type of PR is this?

/kind feature

What this PR does / Why we need it:

  • Updates Allocation.proto to includes Counts and Lists fields in the GameServerAllocation
  • Conversion from allocation.proto to a GameServerAllocation
  • Conversion from a GameServerAllocation to a allocation.proto

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 498b41d to ff2632f Compare May 12, 2023 20:17
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2106ca19-bc33-4b3d-a344-c33ff726e90e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from ff2632f to a4ad28d Compare May 12, 2023 20:27
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 23d46345-1717-4329-8567-ab980e752f89

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot added the lgtm label May 12, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, igooch
Once this PR has been reviewed and has the lgtm label, please assign markmandel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 690b3742-797c-458b-83e9-7b5554d0376d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9621fa94-c147-41df-8f6f-156a54a7503c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from a4ad28d to a54ed9e Compare May 15, 2023 16:34
@google-oss-prow google-oss-prow bot removed the lgtm label May 15, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 05e54555-8d19-4aba-96c9-d8c7f749be81

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from a54ed9e to 8a5d067 Compare May 15, 2023 18:02
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 56986753-48ec-4da7-945f-2ddc55e859dd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 8a5d067 to 62e3756 Compare May 15, 2023 19:48
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f4840a21-a6ea-4d12-b532-6d43a856e0f4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch
Adds CountsAndLists to GameServerAllocation Proto Adds logic for conv…
86062cc 
…erting CountsAndLists from GameServerAllocation to Proto and vice versa
@igooch
Generated Files
020b143
@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 62e3756 to b07d3be Compare May 16, 2023 18:01
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9da28865-ee10-420e-b019-efa871f7184e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from b07d3be to 020b143 Compare May 16, 2023 19:17
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5256f9d2-1a69-44a0-a51f-5c781293bc46

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0d2199a7-cc80-485f-b781-28897cc07ce8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 576c4c22-68f7-4238-a9c5-23fe17b082c5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: feb5d14e-f0af-4076-bcac-a6be574d32dc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3150/head:pr_3150 && git checkout pr_3150
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-b2aaf24-amd64

@gongmax gongmax merged commit 2dc2525 into googleforgames:main May 17, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label May 18, 2023
@igooch igooch mentioned this pull request Jan 18, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongmax gongmax gongmax approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@gongmax gongmax

Labels
kind/feature New features for Agones size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igooch @agones-bot @gongmax @Kalaiselvi84