Add parametric host address #3111

MiniaczQ · 2023-04-19T11:15:56Z

Currently it's only possible to set the port, which is problematic when testing in docker.
This PR replaces the parametric port to URL.

google-cla · 2023-04-19T11:16:00Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

agones-bot · 2023-04-19T12:28:59Z

Build Succeeded 👏

Build Id: 2502e708-7352-4310-a7c2-a76bacf455d6

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-fbfc4cf-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-fbfc4cf-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-fbfc4cf-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-fbfc4cf-amd64
Linux C++ SDK (build): agonessdk-1.32.0-fbfc4cf-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-fbfc4cf-amd64.zip

A preview of the website (the last 30 builds are retained):

https://fbfc4cf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3111/head:pr_3111 && git checkout pr_3111
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-fbfc4cf-amd64

zmerlynn · 2023-04-24T16:00:51Z

Hi! Thanks for your contribution! As indicated in #3111 (comment), we need a signed CLA to accept this - thanks!

agones-bot · 2023-04-26T05:45:25Z

Build Succeeded 👏

Build Id: 6150ddcc-d152-401a-9b28-5285ba44f07b

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-d64291c-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-d64291c-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-d64291c-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-d64291c-amd64
Linux C++ SDK (build): agonessdk-1.32.0-d64291c-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-d64291c-amd64.zip

A preview of the website (the last 30 builds are retained):

https://d64291c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3111/head:pr_3111 && git checkout pr_3111
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-d64291c-amd64

markmandel · 2023-04-26T16:28:07Z

This keeps coming up with a few SDKs - at this point, we should probably just allow it though.

As a review item - this change should also be documented please.

markmandel · 2023-04-26T16:29:47Z

sdks/rust/src/sdk.rs

+        Self::new_internal(addr, keep_alive).await
+    }
+
+    pub async fn new_with_host(


🤔 should this be wrapped in new ?

I added a new method to not break the existing API, but I'd rather have just one method new

Since it has a default that is backward compatible, I think it's fine to have just the new method? Unless I am missing something in the details?

agones-bot · 2023-04-28T05:15:39Z

Build Failed 😱

Build Id: 26575ef6-a563-494a-b57b-31a88a674e8f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-28T06:19:09Z

Build Failed 😱

Build Id: 1aa104d1-be5e-4ade-bfc3-57d7e837e5f0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-28T22:20:24Z

Build Succeeded 👏

Build Id: 18912702-d482-4b54-aec3-d40340b4594e

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-66c0a58-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-66c0a58-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-66c0a58-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-66c0a58-amd64
Linux C++ SDK (build): agonessdk-1.32.0-66c0a58-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-66c0a58-amd64.zip

A preview of the website (the last 30 builds are retained):

https://66c0a58-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3111/head:pr_3111 && git checkout pr_3111
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-66c0a58-amd64

agones-bot · 2023-05-04T07:28:14Z

Build Failed 😱

Build Id: 4f094373-be99-4b2c-b3ea-af11c6a410a6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-05-04T16:55:33Z

OIC - the new method was not backward compatible - sorry, I missed that. So I see the error now in our sdk conformance tests:

   Compiling hyper-timeout v0.4.1
   Compiling tonic v0.5.2
   Compiling rust-simple v0.2.0 (/go/src/agones.dev/agones/test/sdk/rust)
error[E0061]: this function takes 3 arguments but 2 arguments were supplied
   --> src/main.rs:296:9
    |
296 |         agones::Sdk::new(None /* default port */, None /* keep_alive */),
    |         ^^^^^^^^^^^^^^^^ ----                     ---- supplied 2 arguments
    |         |
    |         expected 3 arguments
    |
note: associated function defined here
   --> /go/src/agones.dev/agones/sdks/rust/src/sdk.rs:51:18
    |
51  |     pub async fn new(
    |                  ^^^

error[E0061]: this function takes 3 arguments but 2 arguments were supplied
  --> src/main.rs:48:9
   |
48 |         agones::Sdk::new(None /* default port */, None /* keep_alive */)
   |         ^^^^^^^^^^^^^^^^ ----                     ---- supplied 2 arguments
   |         |
   |         expected 3 arguments
   |
note: associated function defined here
  --> /go/src/agones.dev/agones/sdks/rust/src/sdk.rs:51:18
   |
51 |     pub async fn new(
   |                  ^^^

For more information about this error, try `rustc --explain E0061`.
error: could not compile `rust-simple` due to 2 previous errors

So yeah - two methods may be the better option - sorry about that. I thought it was just using the env vars, I missed the arguments that got passed in.

MiniaczQ · 2023-05-12T08:57:36Z

Bump.
Are there any other problems with this PR?

zmerlynn · 2023-05-12T15:53:53Z

@MiniaczQ @markmandel is OoO right now - I will see if we have anyone else comfortable approving a Rust PR.

agones-bot · 2023-05-12T17:07:56Z

Build Failed 😱

Build Id: bb7cc211-50d7-4e0a-b1a2-d9e1a0e921ed

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-05-17T22:02:52Z

Build Succeeded 👏

Build Id: 8738104f-d9d8-4ee4-a13d-0d615daf2ced

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-5add18c-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-5add18c-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-5add18c-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-5add18c-amd64
Linux C++ SDK (build): agonessdk-1.32.0-5add18c-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-5add18c-amd64.zip

A preview of the website (the last 30 builds are retained):

https://5add18c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3111/head:pr_3111 && git checkout pr_3111
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-5add18c-amd64

agones-bot · 2023-05-17T22:27:47Z

Build Failed 😱

Build Id: 491eff51-d173-4b4d-8cf2-5a7af69c109f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

google-oss-prow · 2023-05-17T23:44:12Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MiniaczQ, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign ericfortin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2023-05-18T00:38:08Z

Build Succeeded 👏

Build Id: d95d4b94-c379-43c3-990f-a98bb82645ce

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-319818b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-319818b-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-319818b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-319818b-amd64
Linux C++ SDK (build): agonessdk-1.32.0-319818b-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-319818b-amd64.zip

A preview of the website (the last 30 builds are retained):

https://319818b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3111/head:pr_3111 && git checkout pr_3111
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-319818b-amd64

google-oss-prow bot requested review from markmandel and roberthbailey April 19, 2023 11:16

google-oss-prow bot added the size/S label Apr 19, 2023

MiniaczQ changed the title ~~feat: parametric host address~~ Add parametric host address Apr 19, 2023

MiniaczQ force-pushed the main branch 2 times, most recently from 4646302 to f5c97f2 Compare April 19, 2023 11:32

google-oss-prow bot added size/M and removed size/S labels Apr 19, 2023

MiniaczQ force-pushed the main branch from f5c97f2 to fbfc4cf Compare April 19, 2023 11:35

markmandel reviewed Apr 26, 2023

View reviewed changes

MiniaczQ force-pushed the main branch from 66c0a58 to 3dfcd5f Compare May 4, 2023 07:14

MiniaczQ force-pushed the main branch from 3dfcd5f to fbfc4cf Compare May 5, 2023 11:59

zmerlynn force-pushed the main branch from fbfc4cf to c87d86c Compare May 12, 2023 15:52

zmerlynn force-pushed the main branch from c87d86c to 5add18c Compare May 17, 2023 19:58

feat: parametric host address

319818b

zmerlynn force-pushed the main branch from 5add18c to 319818b Compare May 17, 2023 22:12

zmerlynn approved these changes May 17, 2023

View reviewed changes

google-oss-prow bot assigned zmerlynn May 17, 2023

google-oss-prow bot added the lgtm label May 17, 2023

zmerlynn enabled auto-merge (squash) May 17, 2023 23:45

zmerlynn merged commit 4408cfc into googleforgames:main May 18, 2023

Kalaiselvi84 added the kind/feature New features for Agones label May 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add parametric host address #3111

Add parametric host address #3111

MiniaczQ commented Apr 19, 2023 •

edited

Loading

google-cla bot commented Apr 19, 2023

agones-bot commented Apr 19, 2023

zmerlynn commented Apr 24, 2023

agones-bot commented Apr 26, 2023

markmandel commented Apr 26, 2023

markmandel Apr 26, 2023

MiniaczQ Apr 26, 2023

markmandel Apr 26, 2023

agones-bot commented Apr 28, 2023

agones-bot commented Apr 28, 2023

agones-bot commented Apr 28, 2023

agones-bot commented May 4, 2023

markmandel commented May 4, 2023

MiniaczQ commented May 12, 2023

zmerlynn commented May 12, 2023

agones-bot commented May 12, 2023

agones-bot commented May 17, 2023

agones-bot commented May 17, 2023

google-oss-prow bot commented May 17, 2023

agones-bot commented May 18, 2023

Add parametric host address #3111

Add parametric host address #3111

Conversation

MiniaczQ commented Apr 19, 2023 • edited Loading

google-cla bot commented Apr 19, 2023

agones-bot commented Apr 19, 2023

zmerlynn commented Apr 24, 2023

agones-bot commented Apr 26, 2023

markmandel commented Apr 26, 2023

markmandel Apr 26, 2023

Choose a reason for hiding this comment

MiniaczQ Apr 26, 2023

Choose a reason for hiding this comment

markmandel Apr 26, 2023

Choose a reason for hiding this comment

agones-bot commented Apr 28, 2023

agones-bot commented Apr 28, 2023

agones-bot commented Apr 28, 2023

agones-bot commented May 4, 2023

markmandel commented May 4, 2023

MiniaczQ commented May 12, 2023

zmerlynn commented May 12, 2023

agones-bot commented May 12, 2023

agones-bot commented May 17, 2023

agones-bot commented May 17, 2023

google-oss-prow bot commented May 17, 2023

agones-bot commented May 18, 2023

MiniaczQ commented Apr 19, 2023 •

edited

Loading