Sort By Counters or Lists during GameServerAllocation 2716 #3091

igooch · 2023-04-12T22:44:19Z

What type of PR is this?
/kind feature

What this PR does / Why we need it:

Adds Priorities "Counter" and "List" that allow Game Servers to be sorted by any Counters or Lists for allocation in a Descending or Ascending manner, where Descending (3, 2, 1, 0, nil) is the default.
The Counter or List sort sorts by the first Priority in the Priorities list. Any subsequent Priority(s) is only used as a tie-breaker in the order in which they are in Priorities list.
Sorting by Counters or Lists at Allocation happens only as a tie-breaker for equal game servers after preferring game servers for state Allocated, being a node that is most allocated, and PlayerTracking if that feature is enabled.
Updates the final tie-breaker for sorting to sort by Game Server name instead of NodeName.

Which issue(s) this PR fixes:
Working on #2716

Special notes for your reviewer:

agones-bot · 2023-04-12T23:41:01Z

Build Succeeded 👏

Build Id: 08c46189-2374-438e-afaa-35de0518b5da

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-db9fff6-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-db9fff6-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-db9fff6-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-db9fff6-amd64
Linux C++ SDK (build): agonessdk-1.31.0-db9fff6-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-db9fff6-amd64.zip

A preview of the website (the last 30 builds are retained):

https://db9fff6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3091/head:pr_3091 && git checkout pr_3091
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-db9fff6-amd64

pkg/apis/allocation/v1/gameserverallocation.go

pkg/gameserverallocations/allocation_cache.go

pkg/gameserverallocations/allocator.go

markmandel · 2023-04-13T00:07:21Z

pkg/gameserverallocations/find.go

@@ -40,6 +40,7 @@ func findGameServerForAllocation(gsa *allocationv1.GameServerAllocation, list []
 	var loop func(list []*agonesv1.GameServer, f func(i int, gs *agonesv1.GameServer))

 	// packed is forward looping, distributed is random looping
+	// TODO: Discuss if we change findGameServerForAllocation so all strategies use forward looping for the the pre-sorted list for each strategy once FeatureCountsAndLists gate is graduated.


For the new version, I think we can throw most of this complexity away, and do simple search and filter -- we don't need this fancy looping construct anymore, since it will be pre-sorted / pre-randomised.

(Also can then also do a duplicated function as well for counts and lists)

Right now we have three paths A) Sort by Allocated and then loop through list. B) Sort by Allocated, then randomly shuffle list, and then loop through randomized list. C) Sort by CountsAndLists and then loop through list.

Where/when should I be randomizing? Should I make a 4th path D) Sort by CountsAndLists, then randomly shuffle list, and then loop through randomized list? Or are you suggesting a different set of paths?

My thought is this - for this part of the code -- the list should already be appropriately sorted when it is passed to it. So it should be a for .. range operation.

Then for each strategy:

Distributed

Randomise first (so that will give us a random distribution within each sorted Allocated/Ready section of the list we have)

Sort by:

Allocated

Count/List as appropriate

Question on the above: Does K8s List already give us a generally random order of GameServers, such that we don't need to bother shuffling it? I'm actually not sure! May be worth checking.

Packed
Sort by:

Allocated First

Packed Strategy (basically what we have now)

Tie break with counts and lists

I hope that makes things clearer?

Why randomize before sorting? I thought we had the entire list of Ready/Allocated game servers here, and not a subset?

If we're keeping our current definitions of Packed and Distributed, then it seems to make more sense to more or less keep the flow as-is:

Sort by Allocated
Tie break sort by number of Ready servers on the Node
Tie break sort by Counts and Lists
Tie break sort by Game Server Name <- Separate discussion on this as it currently tie breaks on NodeName

If Distributed, randomize list

Loop through list to find matching Game Servers (original sorted list for Packed, randomized list for Distributed)

A possible alternative would to first check for matches before sorting the Game Servers, and only sort for the Packed case:

Filter List of Game Servers for Matches

Return unsorted list of Matches for Distributed (not completely random, could be randomized before returning)

Sort List (same as above) and return sorted list of Matches for Packed

Another possible alternative would to first check for matches before sorting the Game Servers, and then sort for both cases then randomize for distributed:

Filter List of Game Servers for Matches

Sort List (same as above)
Return sorted list of Matches for Packed
Randomize then return list of Matches for Distributed

One benefit to do sorting before matching is that we can return fast when we find the first match. If we do matching first, we have to go though all the GameServers to find out the ones that match, then perform sorting for them, and then return the first one. Though Mathematically speaking there is no difference on the time complexity (they both are O(nlogn) for sorting and O(n) for matching).

I kind of agree on Mark, the sorting/randomization should happen in ListSortedGameServers. This gives us a central place to maintain different sorting logic (random is also a kind of sorting) for different scheduling strategy, and use the findGameServerForAllocation purely to pick the first GameServer that match the selectors from the sorted GameServer list. What I'm not quite convinced is whether we should apply the sorting based on Allocated and Count/List after the randomize for distributed strategy. Right now, for distributed strategy, it looks like the although we perform the sorting based on Allocated and player tracking in ListSortedGameServers, we shuffle the list eventually in findGameServerForAllocation. I.e. it's a totally randomize without any sorting. So instead of "Randomize first -> Sort by: Allocated and Count/List as appropriate", maybe just a randomize in ListSortedGameServers is good enough for distributed strategy. This also fit our definition of Distributed strategy better. ("Distributed" is aimed at static Kubernetes clusters, wherein we want to distribute resources across the entire cluster)

Another thought may outside of the scope. Can we be more smart for Distributed strategy? For example, Instead of using randomize to achieve distributed, can we sort on the GameServer count per node and pick the one node with least GameServers on it? I know a lot of other complexity will involve for the other allocation criteria, but just want to call out this basic thoughts which can make the distributed allocation deterministic. Distributed should not equal to Random, and Random sounds like a different placement/allocation strategy.

With the above being said, I think the current findGameServerForAllocation totally works fine. We can leave all the refactoring outside this PR.

pkg/apis/allocation/v1/gameserverallocation.go

pkg/gameserverallocations/allocation_cache.go

agones-bot · 2023-04-14T22:45:40Z

Build Succeeded 👏

Build Id: 09c52bde-1174-4ff8-8fb3-fd750e99cda5

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-ca0fce5-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-ca0fce5-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-ca0fce5-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-ca0fce5-amd64
Linux C++ SDK (build): agonessdk-1.31.0-ca0fce5-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-ca0fce5-amd64.zip

A preview of the website (the last 30 builds are retained):

https://ca0fce5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3091/head:pr_3091 && git checkout pr_3091
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-ca0fce5-amd64

markmandel · 2023-04-14T23:03:07Z

pkg/apis/allocation/v1/gameserverallocation.go

+		})
+	}
+
+	if !(p.Order == Ascending || p.Order == Descending || p.Order == "") {


I'm assuming Order will be defaulted, so checking for "" is probably not something we need to do? (or want to if we have defaulting)

I haven't done any defaulting. Where in the code should I do defaulting for this?

pkg/apis/allocation/v1/gameserverallocation.go

pkg/gameserverallocations/allocation_cache.go

pkg/apis/allocation/v1/gameserverallocation.go

agones-bot · 2023-04-17T17:18:22Z

Build Failed 😱

Build Id: 5b55855c-a9ec-464c-818a-f783ef3a664a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-17T17:34:36Z

Build Failed 😱

Build Id: 08c0fe60-14a7-4e24-95fd-9bd91c156e3b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-17T18:35:33Z

Build Succeeded 👏

Build Id: 8f81d742-e8e7-46be-80aa-64408fcc408a

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-e3a669f-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-e3a669f-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-e3a669f-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-e3a669f-amd64
Linux C++ SDK (build): agonessdk-1.31.0-e3a669f-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-e3a669f-amd64.zip

A preview of the website (the last 30 builds are retained):

https://e3a669f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3091/head:pr_3091 && git checkout pr_3091
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-e3a669f-amd64

agones-bot · 2023-04-18T16:52:41Z

Build Failed 😱

Build Id: 2b31ade1-b986-4ffc-a90c-1076463eeb31

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

igooch · 2023-04-18T17:19:58Z

pkg/gameserverallocations/allocation_cache.go

 		// finally sort lexicographically, so we have a stable order
-		return gs1.Status.NodeName < gs2.Status.NodeName
+		return gs1.GetObjectMeta().GetName() < gs2.GetObjectMeta().GetName()


@markmandel I changed this to the ObjectMeta.Name instead of the Status.NodeName because the NodeName is not unique, so this didn't create a stable order. (I discovered this during test TestAllocationCacheListSortedGameServers as gs2 and gs4 are the same when comparing by NodeName.)

This change assumes that both 1) all Game Servers have ObjectMeta.Name, and 2) All ObjectMeta.Name are unique. Are these correct assumptions? If those assumptions are not correct, then this change would also not create a stable order. Would it be better to use the ObjectMeta.UID? Or would it be better to leave things as-is? Or should we leave it out for the sake of not making changes that are not behind a feature gate?

agones-bot · 2023-04-18T18:04:34Z

Build Succeeded 👏

Build Id: fd8bdc9a-849d-423b-857d-eebda4397fc9

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-8895853-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-8895853-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-8895853-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-8895853-amd64
Linux C++ SDK (build): agonessdk-1.31.0-8895853-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-8895853-amd64.zip

A preview of the website (the last 30 builds are retained):

https://8895853-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3091/head:pr_3091 && git checkout pr_3091
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-8895853-amd64

agones-bot · 2023-04-19T16:50:53Z

Build Failed 😱

Build Id: ccc80805-9b8d-48e1-aa47-8c916fa1dadf

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-19T17:11:37Z

Build Failed 😱

Build Id: 7157a452-c1e2-4d0b-9bc8-5068ad327887

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-19T18:16:29Z

Build Succeeded 👏

Build Id: 48802fd3-b1aa-475d-8698-0d958111f929

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-6ca5667-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-6ca5667-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-6ca5667-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-6ca5667-amd64
Linux C++ SDK (build): agonessdk-1.32.0-6ca5667-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-6ca5667-amd64.zip

A preview of the website (the last 30 builds are retained):

https://6ca5667-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3091/head:pr_3091 && git checkout pr_3091
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-6ca5667-amd64

gongmax

Can we add unit test coverage for the new validate logic added in gameserverallocation.go?

gongmax · 2023-04-19T18:30:32Z

pkg/gameserverallocations/allocation_cache.go

 		// finally sort lexicographically, so we have a stable order
-		return gs1.Status.NodeName < gs2.Status.NodeName
+		return gs1.GetObjectMeta().GetName() < gs2.GetObjectMeta().GetName()


I think the assumptions are correct. https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata

gongmax · 2023-04-19T20:59:56Z

pkg/gameserverallocations/find.go

@@ -40,6 +40,7 @@ func findGameServerForAllocation(gsa *allocationv1.GameServerAllocation, list []
 	var loop func(list []*agonesv1.GameServer, f func(i int, gs *agonesv1.GameServer))

 	// packed is forward looping, distributed is random looping
+	// TODO: Discuss if we change findGameServerForAllocation so all strategies use forward looping for the the pre-sorted list for each strategy once FeatureCountsAndLists gate is graduated.


One benefit to do sorting before matching is that we can return fast when we find the first match. If we do matching first, we have to go though all the GameServers to find out the ones that match, then perform sorting for them, and then return the first one. Though Mathematically speaking there is no difference on the time complexity (they both are O(nlogn) for sorting and O(n) for matching).

I kind of agree on Mark, the sorting/randomization should happen in ListSortedGameServers. This gives us a central place to maintain different sorting logic (random is also a kind of sorting) for different scheduling strategy, and use the findGameServerForAllocation purely to pick the first GameServer that match the selectors from the sorted GameServer list. What I'm not quite convinced is whether we should apply the sorting based on Allocated and Count/List after the randomize for distributed strategy. Right now, for distributed strategy, it looks like the although we perform the sorting based on Allocated and player tracking in ListSortedGameServers, we shuffle the list eventually in findGameServerForAllocation. I.e. it's a totally randomize without any sorting. So instead of "Randomize first -> Sort by: Allocated and Count/List as appropriate", maybe just a randomize in ListSortedGameServers is good enough for distributed strategy. This also fit our definition of Distributed strategy better. ("Distributed" is aimed at static Kubernetes clusters, wherein we want to distribute resources across the entire cluster)

Another thought may outside of the scope. Can we be more smart for Distributed strategy? For example, Instead of using randomize to achieve distributed, can we sort on the GameServer count per node and pick the one node with least GameServers on it? I know a lot of other complexity will involve for the other allocation criteria, but just want to call out this basic thoughts which can make the distributed allocation deterministic. Distributed should not equal to Random, and Random sounds like a different placement/allocation strategy.

pkg/gameserverallocations/allocator.go

agones-bot · 2023-04-19T22:32:26Z

Build Succeeded 👏

Build Id: 381d855b-36ed-4196-8c03-ee407227bcae

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-e8d646b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-e8d646b-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-e8d646b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-e8d646b-amd64
Linux C++ SDK (build): agonessdk-1.32.0-e8d646b-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-e8d646b-amd64.zip

A preview of the website (the last 30 builds are retained):

https://e8d646b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3091/head:pr_3091 && git checkout pr_3091
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-e8d646b-amd64

agones-bot · 2023-04-19T23:41:54Z

Build Failed 😱

Build Id: cea29962-d9b3-40b6-ad40-a43196ea4e1f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-20T02:09:56Z

Build Succeeded 👏

Build Id: 930ad8cc-c190-42ef-8d4d-930430cc2f6d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-264e9cd-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-264e9cd-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-264e9cd-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-264e9cd-amd64
Linux C++ SDK (build): agonessdk-1.32.0-264e9cd-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-264e9cd-amd64.zip

A preview of the website (the last 30 builds are retained):

https://264e9cd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3091/head:pr_3091 && git checkout pr_3091
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-264e9cd-amd64

markmandel

Looks like a good set of initial changes 👍🏻 LGTM!

markmandel · 2023-04-20T19:21:34Z

pkg/gameserverallocations/allocation_cache.go

 		// finally sort lexicographically, so we have a stable order
-		return gs1.Status.NodeName < gs2.Status.NodeName
+		return gs1.GetObjectMeta().GetName() < gs2.GetObjectMeta().GetName()


Those assumptions are correct - so this sounds like a good change 👍🏻

google-oss-prow · 2023-04-20T19:23:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow bot added the do-not-merge/work-in-progress label Apr 12, 2023

google-oss-prow bot requested review from aLekSer and roberthbailey April 12, 2023 22:44

google-oss-prow bot added the size/XL label Apr 12, 2023

markmandel reviewed Apr 13, 2023

View reviewed changes

gongmax reviewed Apr 13, 2023

View reviewed changes

pkg/apis/allocation/v1/gameserverallocation.go Show resolved Hide resolved

pkg/gameserverallocations/allocation_cache.go Outdated Show resolved Hide resolved

pkg/gameserverallocations/allocation_cache.go Outdated Show resolved Hide resolved

igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from f2f7fd7 to ca0fce5 Compare April 14, 2023 21:27

markmandel reviewed Apr 14, 2023

View reviewed changes

igooch commented Apr 17, 2023

View reviewed changes

pkg/apis/allocation/v1/gameserverallocation.go Outdated Show resolved Hide resolved

igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from f267cb1 to 8418791 Compare April 17, 2023 17:17

google-oss-prow bot added size/XXL and removed size/XL labels Apr 17, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from 8418791 to e3a669f Compare April 17, 2023 17:36

igooch force-pushed the arbitrary-counts-lists-2716 branch from e3a669f to 924c6f1 Compare April 18, 2023 16:42

igooch force-pushed the arbitrary-counts-lists-2716 branch from 924c6f1 to 8895853 Compare April 18, 2023 17:06

igooch commented Apr 18, 2023

View reviewed changes

igooch force-pushed the arbitrary-counts-lists-2716 branch from 8895853 to 7ada61e Compare April 19, 2023 16:27

google-oss-prow bot added size/XL size/XXL and removed size/XXL size/XL labels Apr 19, 2023

igooch changed the title ~~Arbitrary counts lists 2716~~ Sort By Counters and Lists during GameServerAllocation 2716 Apr 19, 2023

GameServerAllocation sorting based on CountsAndLists Priorities

32b97e2

igooch force-pushed the arbitrary-counts-lists-2716 branch from 4864d08 to ac45472 Compare April 19, 2023 16:40

igooch marked this pull request as ready for review April 19, 2023 16:40

google-oss-prow bot removed the do-not-merge/work-in-progress label Apr 19, 2023

igooch changed the title ~~Sort By Counters and Lists during GameServerAllocation 2716~~ Sort By Counters or Lists during GameServerAllocation 2716 Apr 19, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from ac45472 to 6ca5667 Compare April 19, 2023 17:01

gongmax reviewed Apr 19, 2023

View reviewed changes

igooch added 2 commits April 19, 2023 21:27

Updates to follow existing patterns for Packed and Distributed

21ded89

Generated Files

e8d646b

igooch force-pushed the arbitrary-counts-lists-2716 branch from 6ca5667 to e8d646b Compare April 19, 2023 21:27

Adds additional tests for CountsAndLists validation

264e9cd

gongmax approved these changes Apr 20, 2023

View reviewed changes

google-oss-prow bot assigned gongmax Apr 20, 2023

google-oss-prow bot added the lgtm label Apr 20, 2023

markmandel approved these changes Apr 20, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Apr 20, 2023

google-oss-prow bot added the approved label Apr 20, 2023

markmandel merged commit 5911f0c into googleforgames:main Apr 20, 2023

Kalaiselvi84 added the kind/feature New features for Agones label May 18, 2023

igooch mentioned this pull request Jan 18, 2024

Request for igooch to become Approver #3600

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sort By Counters or Lists during GameServerAllocation 2716 #3091

Sort By Counters or Lists during GameServerAllocation 2716 #3091

igooch commented Apr 12, 2023 •

edited

Loading

agones-bot commented Apr 12, 2023

markmandel Apr 13, 2023

igooch Apr 17, 2023

markmandel Apr 18, 2023

igooch Apr 18, 2023 •

edited

Loading

gongmax Apr 19, 2023

gongmax Apr 19, 2023

agones-bot commented Apr 14, 2023

markmandel Apr 14, 2023

igooch Apr 17, 2023

agones-bot commented Apr 17, 2023

agones-bot commented Apr 17, 2023

agones-bot commented Apr 17, 2023

agones-bot commented Apr 18, 2023

igooch Apr 18, 2023 •

edited

Loading

agones-bot commented Apr 18, 2023

agones-bot commented Apr 19, 2023

agones-bot commented Apr 19, 2023

agones-bot commented Apr 19, 2023

gongmax left a comment

gongmax Apr 19, 2023

gongmax Apr 19, 2023

agones-bot commented Apr 19, 2023

agones-bot commented Apr 19, 2023

agones-bot commented Apr 20, 2023

markmandel left a comment

markmandel Apr 20, 2023

google-oss-prow bot commented Apr 20, 2023

Sort By Counters or Lists during GameServerAllocation 2716 #3091

Sort By Counters or Lists during GameServerAllocation 2716 #3091

Conversation

igooch commented Apr 12, 2023 • edited Loading

agones-bot commented Apr 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

igooch Apr 18, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Apr 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Apr 17, 2023

agones-bot commented Apr 17, 2023

agones-bot commented Apr 17, 2023

agones-bot commented Apr 18, 2023

igooch Apr 18, 2023 • edited Loading

Choose a reason for hiding this comment

agones-bot commented Apr 18, 2023

agones-bot commented Apr 19, 2023

agones-bot commented Apr 19, 2023

agones-bot commented Apr 19, 2023

gongmax left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Apr 19, 2023

agones-bot commented Apr 19, 2023

agones-bot commented Apr 20, 2023

markmandel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

google-oss-prow bot commented Apr 20, 2023

igooch commented Apr 12, 2023 •

edited

Loading

igooch Apr 18, 2023 •

edited

Loading

igooch Apr 18, 2023 •

edited

Loading