Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tags for cluster, location, commit to e2e-test builds #3074

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Add tags for cluster, location, commit to e2e-test builds #3074

merged 2 commits into from
Apr 7, 2023

Conversation

zmerlynn
Copy link
Collaborator

@zmerlynn zmerlynn commented Apr 6, 2023 •
edited
Loading

Tags will allow us to slice test failures more easily in Logs Explorer / BigQuery

Adding VERBOSE: allows us to split up the primary and verbose output in the BQ sink more easily.

Together, we should be able to extract test failures more easily, in theory.

Looks similar to this, but I took out the double dashes:

image

@zmerlynn zmerlynn requested a review from gongmax April 6, 2023 16:41
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7d8245e5-9d46-4526-91e6-0c1e1e2d230b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0d25ac2c-4a8d-4981-bec3-43617eea41d5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ecf46c90-9518-4d7a-a69d-8553e783fbb2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5f2bacc0-6151-42f0-8486-3fc59fcdeb4a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3074/head:pr_3074 && git checkout pr_3074
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-6b68944-amd64

@zmerlynn
Add tags for cluster, location, commit to e2e-test builds
78bc8f1 
This will allow us to slice test failures more easily in
Logs Explorer / BigQuery
@zmerlynn zmerlynn changed the title WIP: Can we tag builds with config? Add tags for cluster, location, commit to e2e-test builds Apr 6, 2023
@zmerlynn zmerlynn marked this pull request as ready for review April 6, 2023 23:03
@zmerlynn zmerlynn removed the request for review from aLekSer April 6, 2023 23:03
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Apr 6, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e63ec42e-b7d1-4522-88c6-988f428eaf36

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3074/head:pr_3074 && git checkout pr_3074
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-6a469bc-amd64

gongmax
gongmax approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@gongmax gongmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@google-oss-prow google-oss-prow bot added the lgtm label Apr 7, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign cyriltovena for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gongmax gongmax merged commit df77e7b into googleforgames:main Apr 7, 2023
Kalaiselvi84 added a commit to Kalaiselvi84/agones that referenced this pull request Apr 7, 2023
@Kalaiselvi84
Merge pull request #40 from Kalaiselvi84/main
02fb686 
Add tags for cluster, location, commit to e2e-test builds (googleforgames#3074)
@Kalaiselvi84 Kalaiselvi84 added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Apr 10, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023
Kalaiselvi84 pushed a commit to Kalaiselvi84/agones that referenced this pull request Apr 11, 2023
@zmerlynn @Kalaiselvi84
Add tags for cluster, location, commit to e2e-test builds (googleforg…
5b30f40 
…ames#3074)

* Add tags for cluster, location, commit to e2e-test builds

This will allow us to slice test failures more easily in
Logs Explorer / BigQuery

* Delineate verbose output more easily in firehose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongmax gongmax gongmax approved these changes

@markmandel markmandel Awaiting requested review from markmandel

Assignees

@gongmax gongmax

Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break lgtm size/S
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zmerlynn @agones-bot @gongmax @Kalaiselvi84