Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the state bucket exists before creating e2e test clusters #3014

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented Mar 2, 2023

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
We have adopted remote backend (GCS) for the e2e test cluster terraform state, but the target for creating e2e test clusters doesn't verify whether the state bucket exists, which introduces confusion. This PR adds dependencies to the creating e2e test clusters target to verify and create the state bucket if it isn't created yet.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 492d7f6e-6c3a-44cb-bb2b-47a029186759

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3014/head:pr_3014 && git checkout pr_3014
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-c065ae6-amd64

@gongmax gongmax marked this pull request as ready for review March 2, 2023 20:48
@google-oss-prow google-oss-prow bot requested a review from aLekSer March 2, 2023 20:48
@zmerlynn zmerlynn self-assigned this Mar 2, 2023
@google-oss-prow google-oss-prow bot added the lgtm label Mar 2, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign cyriltovena for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@zmerlynn zmerlynn enabled auto-merge (squash) March 2, 2023 21:52
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 46bf663c-8188-494c-a7fc-1905dced1f4f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3014/head:pr_3014 && git checkout pr_3014
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-458f808-amd64

@zmerlynn zmerlynn merged commit 0db51dd into googleforgames:main Mar 2, 2023
@gongmax gongmax deleted the ensure-bucket branch March 22, 2023 22:56
@Kalaiselvi84 Kalaiselvi84 added the kind/bug These are bugs. label Apr 10, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants