Add autopilot instructions to doc as Alpha #3004

shannonxtreme · 2023-02-28T19:52:40Z

Add alpha stage instructions for GKE autopilot in the GKE getting started doc.

Based on the discussion in #2985, which I'll close for now.

Reviewer notes

Need the correct Agones release version for the publishVersion widget
Need reviews around style
This PR doesnt clean up older branding and UI instructions on the page (but might be a followup)

/kind documentation
/cc @zmerlynn @markmandel

agones-bot · 2023-02-28T20:43:59Z

Build Failed 😱

Build Id: affe623d-371f-4ffe-86a0-1294ebbb0e1e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

site/content/en/docs/Installation/Creating Cluster/gke.md

agones-bot · 2023-03-01T17:56:59Z

Build Failed 😱

Build Id: 3283f84f-b88a-4f7a-8847-c65110a5cdc0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

shannonxtreme · 2023-03-01T18:01:42Z

Is it my link structure?

agones-bot · 2023-03-01T18:03:32Z

Build Failed 😱

Build Id: 5a9c93a7-c031-4496-b2a0-451d076c4ee8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

zmerlynn · 2023-03-01T18:07:26Z

@shannonxtreme I think it's an improper ref?

Error: Error building site: "/go/src/agones.dev/agones/site/content/en/docs/Installation/Creating Cluster/gke.md:107:39": failed to render shortcode "relref": failed to process shortcode: template: _internal/shortcodes/relref.html:1:3: executing "_internal/shortcodes/relref.html" at <relref . .Params>: error calling relref: invalid number of arguments to ref

site/content/en/docs/Installation/Creating Cluster/gke.md

agones-bot · 2023-03-01T19:33:47Z

Build Failed 😱

Build Id: 2f738820-2186-4413-9548-0e5a5f827535

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-01T19:38:10Z

Build Failed 😱

Build Id: 36e32383-5650-4155-b950-4c64a5ab6e40

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

site/content/en/docs/Installation/Creating Cluster/gke.md

agones-bot · 2023-03-01T20:54:08Z

Build Failed 😱

Build Id: b64b1a08-4f4e-48d3-8fcb-a42da70c75ea

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-02T00:57:03Z

Build Succeeded 👏

Build Id: 2ea894c8-a729-4fdd-996f-bca975a2a61f

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-6bdd1b3-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-6bdd1b3-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-6bdd1b3-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-6bdd1b3-amd64
Linux C++ SDK (build): agonessdk-1.30.0-6bdd1b3-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-6bdd1b3-amd64.zip

A preview of the website (the last 30 builds are retained):

https://6bdd1b3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3004/head:pr_3004 && git checkout pr_3004
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-6bdd1b3-amd64

site/content/en/docs/Installation/Creating Cluster/gke.md

agones-bot · 2023-03-02T16:59:27Z

Build Failed 😱

Build Id: 4ac89402-701d-437a-9838-6f82639c65a9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-02T17:52:01Z

Build Failed 😱

Build Id: 87ce1801-9f2f-4414-b3ee-c8c1303cf5a9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

site/content/en/docs/Installation/Creating Cluster/gke.md

agones-bot · 2023-03-02T19:38:18Z

Build Failed 😱

Build Id: 19bc547e-0ad1-4b5f-8b05-50c244100990

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-02T21:47:46Z

Build Failed 😱

Build Id: d67baf84-4c69-40d9-96e4-2861ae3254e1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

site/content/en/docs/Installation/Creating Cluster/gke.md

zmerlynn · 2023-03-03T17:53:14Z

This LGTM - if you can address @markmandel's comments, I'll give it another pass and merge.

zmerlynn · 2023-03-03T18:02:14Z

site/content/en/docs/Installation/Creating Cluster/gke.md

+  [GKE release channel](https://cloud.google.com/kubernetes-engine/docs/release-notes#current_versions)
+  for the cluster. Can be one of `rapid`, `regular`, or `stable`. The default
+  is `regular`. The release channel must use a
+  [supported Kubernetes version]({{<ref "/docs/Installation#usage-requirements">}}).


Should we note here that even though the channel has a default, other versions are available with --cluster-version?

The annoying thing is I can't find a page that has the equivalent data to go/gke-versions. You can infer it from channel release notes on https://cloud.google.com/kubernetes-engine/docs/release-notes, but there's not a simple table. And on Autopilot the version doesn't show up in Pantheon. So I'm not sure what to link to outside of gcloud container get-server-config --zone us-west1, which is.. not super friendly.

Played with gcloud a bit and you can run gcloud container get-server-config --region=us-central1 --flatten=channels --filter="(channels.channel~REGULAR)" --format="yaml(channels)" which is neater

zmerlynn · 2023-03-03T18:05:21Z

site/content/en/docs/Installation/Creating Cluster/gke.md

+In Autopilot clusters, GKE manages the nodes, so you won't create dedicated
+node pools for Agones system components or for metrics collection. The node
+affinity rules in the Agones installation manifests tell GKE to separate system
+and metrics Pods onto dedicated nodes automatically.


The node
affinity rules in the Agones installation manifests tell GKE to separate system
and metrics Pods onto dedicated nodes automatically.

This part is opposite of what I intended in the UG as well. I might just leave this part out for now - I'm really thinking we need a guide page rather than dumping all of this on the install page, and I have some stuff to say about separation at a greater depth, but it seems cluttery to put it here.

Does that effect not happen then? I noticed the node tolerations in the manifests

The problem is that for pod anti-affinity, you have to have >0.25 vCPU pods, so I backed off on using them in general. The tolerations are still there, I think, but I don't think they're doing anything right now.

agones-bot · 2023-03-03T19:12:34Z

Build Failed 😱

Build Id: 1b7f2e00-c41a-443f-8054-0c7189028453

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

site/content/en/docs/Installation/Creating Cluster/gke.md

google-oss-prow · 2023-03-03T21:24:48Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shannonxtreme, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign ericfortin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2023-03-03T21:25:11Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-03-03T22:36:40Z

Build Succeeded 👏

Build Id: 86ebbc83-dd2b-4629-a3fe-981537e70888

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-a640f1a-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-a640f1a-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-a640f1a-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-a640f1a-amd64
Linux C++ SDK (build): agonessdk-1.31.0-a640f1a-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-a640f1a-amd64.zip

A preview of the website (the last 30 builds are retained):

https://a640f1a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3004/head:pr_3004 && git checkout pr_3004
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-a640f1a-amd64

agones-bot · 2023-03-03T23:24:56Z

Build Failed 😱

Build Id: 0e6a3b12-92c8-4323-b1bf-fc811ede27ea

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-03-04T00:30:11Z

Build Succeeded 👏

Build Id: 4dd0d4d5-8770-4338-aa1c-29c3ff56454d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-7b8f739-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-7b8f739-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-7b8f739-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-7b8f739-amd64
Linux C++ SDK (build): agonessdk-1.31.0-7b8f739-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-7b8f739-amd64.zip

A preview of the website (the last 30 builds are retained):

https://7b8f739-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3004/head:pr_3004 && git checkout pr_3004
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-7b8f739-amd64

google-oss-prow bot requested review from markmandel and zmerlynn February 28, 2023 19:52

google-oss-prow bot added the size/M label Feb 28, 2023

markmandel reviewed Feb 28, 2023

View reviewed changes

site/content/en/docs/Installation/Creating Cluster/gke.md Outdated Show resolved Hide resolved

site/content/en/docs/Installation/Creating Cluster/gke.md Outdated Show resolved Hide resolved

site/content/en/docs/Installation/Creating Cluster/gke.md Outdated Show resolved Hide resolved

shannonxtreme force-pushed the autopilot-alpha branch 2 times, most recently from 0ea3e62 to 349e907 Compare March 1, 2023 17:52

zmerlynn reviewed Mar 1, 2023

View reviewed changes

site/content/en/docs/Installation/Creating Cluster/gke.md Outdated Show resolved Hide resolved

site/content/en/docs/Installation/Creating Cluster/gke.md Outdated Show resolved Hide resolved

site/content/en/docs/Installation/Creating Cluster/gke.md Outdated Show resolved Hide resolved

shannonxtreme force-pushed the autopilot-alpha branch 2 times, most recently from a3daef4 to 9104bd5 Compare March 1, 2023 19:28

zmerlynn reviewed Mar 1, 2023

View reviewed changes

site/content/en/docs/Installation/Creating Cluster/gke.md Outdated Show resolved Hide resolved

shannonxtreme force-pushed the autopilot-alpha branch from 9104bd5 to d7bd68d Compare March 1, 2023 20:10

shannonxtreme force-pushed the autopilot-alpha branch from d7bd68d to 6bdd1b3 Compare March 1, 2023 23:00

markmandel reviewed Mar 2, 2023

View reviewed changes

shannonxtreme force-pushed the autopilot-alpha branch from 6bdd1b3 to af2cc9b Compare March 2, 2023 16:49

google-oss-prow bot added size/L and removed size/M labels Mar 2, 2023

shannonxtreme force-pushed the autopilot-alpha branch 2 times, most recently from 9371344 to a5a9280 Compare March 2, 2023 17:43

shannonxtreme requested a review from markmandel March 2, 2023 17:43

zmerlynn reviewed Mar 2, 2023

View reviewed changes

site/content/en/docs/Installation/Creating Cluster/gke.md Outdated Show resolved Hide resolved

roberthbailey reviewed Mar 2, 2023

View reviewed changes

site/content/en/docs/Installation/Creating Cluster/gke.md Outdated Show resolved Hide resolved

site/content/en/docs/Installation/Creating Cluster/gke.md Show resolved Hide resolved

shannonxtreme force-pushed the autopilot-alpha branch from 98a7a81 to 8317a85 Compare March 2, 2023 19:53

markmandel reviewed Mar 2, 2023

View reviewed changes

zmerlynn reviewed Mar 3, 2023

View reviewed changes

shannonxtreme force-pushed the autopilot-alpha branch from 8317a85 to 45a0e11 Compare March 3, 2023 19:02

zmerlynn reviewed Mar 3, 2023

View reviewed changes

site/content/en/docs/Installation/Creating Cluster/gke.md Outdated Show resolved Hide resolved

shannonxtreme force-pushed the autopilot-alpha branch from 45a0e11 to 322ff3e Compare March 3, 2023 21:04

zmerlynn approved these changes Mar 3, 2023

View reviewed changes

google-oss-prow bot assigned zmerlynn Mar 3, 2023

google-oss-prow bot added the lgtm label Mar 3, 2023

zmerlynn force-pushed the autopilot-alpha branch from c998ffb to a640f1a Compare March 3, 2023 21:25

google-oss-prow bot removed the lgtm label Mar 3, 2023

zmerlynn enabled auto-merge (squash) March 3, 2023 21:25

shannonxtreme and others added 2 commits March 3, 2023 15:08

Add autopilot instructions to doc as Alpha

930e4a6

Fix minor type.

7b8f739

zmerlynn force-pushed the autopilot-alpha branch from a640f1a to 7b8f739 Compare March 3, 2023 23:08

zmerlynn merged commit 5face54 into googleforgames:main Mar 4, 2023

Kalaiselvi84 added the kind/documentation Documentation for Agones label Apr 10, 2023

Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add autopilot instructions to doc as Alpha #3004

Add autopilot instructions to doc as Alpha #3004

shannonxtreme commented Feb 28, 2023

agones-bot commented Feb 28, 2023

agones-bot commented Mar 1, 2023

shannonxtreme commented Mar 1, 2023

agones-bot commented Mar 1, 2023

zmerlynn commented Mar 1, 2023

agones-bot commented Mar 1, 2023

agones-bot commented Mar 1, 2023

agones-bot commented Mar 1, 2023

agones-bot commented Mar 2, 2023

agones-bot commented Mar 2, 2023

agones-bot commented Mar 2, 2023

agones-bot commented Mar 2, 2023

agones-bot commented Mar 2, 2023

zmerlynn commented Mar 3, 2023

zmerlynn Mar 3, 2023

shannonxtreme Mar 3, 2023

zmerlynn Mar 3, 2023

shannonxtreme Mar 3, 2023

shannonxtreme Mar 3, 2023

zmerlynn Mar 3, 2023

agones-bot commented Mar 3, 2023

google-oss-prow bot commented Mar 3, 2023

google-oss-prow bot commented Mar 3, 2023

agones-bot commented Mar 3, 2023

agones-bot commented Mar 3, 2023

agones-bot commented Mar 4, 2023

Add autopilot instructions to doc as Alpha #3004

Add autopilot instructions to doc as Alpha #3004

Conversation

shannonxtreme commented Feb 28, 2023

Reviewer notes

agones-bot commented Feb 28, 2023

agones-bot commented Mar 1, 2023

shannonxtreme commented Mar 1, 2023

agones-bot commented Mar 1, 2023

zmerlynn commented Mar 1, 2023

agones-bot commented Mar 1, 2023

agones-bot commented Mar 1, 2023

agones-bot commented Mar 1, 2023

agones-bot commented Mar 2, 2023

agones-bot commented Mar 2, 2023

agones-bot commented Mar 2, 2023

agones-bot commented Mar 2, 2023

agones-bot commented Mar 2, 2023

zmerlynn commented Mar 3, 2023

zmerlynn Mar 3, 2023

Choose a reason for hiding this comment

shannonxtreme Mar 3, 2023

Choose a reason for hiding this comment

zmerlynn Mar 3, 2023

Choose a reason for hiding this comment

shannonxtreme Mar 3, 2023

Choose a reason for hiding this comment

shannonxtreme Mar 3, 2023

Choose a reason for hiding this comment

zmerlynn Mar 3, 2023

Choose a reason for hiding this comment

agones-bot commented Mar 3, 2023

google-oss-prow bot commented Mar 3, 2023

google-oss-prow bot commented Mar 3, 2023

agones-bot commented Mar 3, 2023

agones-bot commented Mar 3, 2023

agones-bot commented Mar 4, 2023