Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extensions Resource Dashboard #2993

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Conversation

chiayi
Copy link
Contributor

@chiayi chiayi commented Feb 23, 2023

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:
This adds a Grafana dashboard for Extensions resource usage.

Which issue(s) this PR fixes:
Work on #2797

Special notes for your reviewer:
Screenshot of the dashboard:
image

@markmandel
Copy link
Member

Are there new metrics we should document here: https://agones.dev/site/docs/guides/metrics/ ?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6eaf8273-ae7a-4cd6-a848-229312053c8d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2993/head:pr_2993 && git checkout pr_2993
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-75ebe45-amd64

@chiayi
Copy link
Contributor Author

chiayi commented Feb 23, 2023

Still need to add to metrics docs. But there are not any new metrics that need to be documented, just different parameters.

@zmerlynn
Copy link
Collaborator

Are there new metrics we should document here: https://agones.dev/site/docs/guides/metrics/ ?

There will be new pods with new labels (e.g. agones_dev_role of extensions) but the metrics are the same. They're just forked, streams, basically.

@markmandel
Copy link
Member

Got it - SGTM!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chiayi, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn
Copy link
Collaborator

Taking a sec to test that this works on my setup, too, for curiousity.

@zmerlynn zmerlynn merged commit d5d692b into googleforgames:main Feb 23, 2023
chiayi added a commit to chiayi/agones that referenced this pull request Feb 24, 2023
chiayi added a commit to chiayi/agones that referenced this pull request Feb 24, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants