Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocation Endpoint: Fix Makefile to correctly call docker build #2933

Merged
merged 3 commits into from
Jan 26, 2023
Merged

Allocation Endpoint: Fix Makefile to correctly call docker build #2933

merged 3 commits into from
Jan 26, 2023

Conversation

abmarcum
Copy link
Contributor

The Allocation Endpoint container image will not run due to the allocation-endpoint-proxy binary being incompletely built.

When you try to run the container image, the following error occurs:

exec: "/allocation-endpoint-proxy": permission denied:

This PR fixes the permission error by modifying the Makefile to include the correct build path when building the allocation-endpoint-proxy binary.

Once the PR has been merged, an account with the appropriate repository permissions will need to re-publish the Allocation Endpoint container image.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a50b42c6-26a7-4ab3-84fe-a14aa313be0b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel
markmandel reviewed Jan 26, 2023
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're fixing the image, we should also:

Increment the version number (0.3) here (and I can push up a new build once merged):

agones/examples/allocation-endpoint/Makefile

Line 31 in 10490f0

server_tag = $(REPOSITORY)/allocation-endpoint-proxy:0.2

And also in the Terraform here:

agones/examples/allocation-endpoint/terraform/variable.tf

Line 23 in 10490f0

default = "us-docker.pkg.dev/agones-images/examples/allocation-endpoint-proxy:0.2"

So that it's fixed everywhere.

Good catch!

@markmandel
Copy link
Member

Took the Makefile changes for a spin - all works correctly 👍🏻

@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Jan 26, 2023
@abmarcum
Copy link
Contributor Author

I have updated the the version number in both the Makefile and the terraform variable.tf.

@google-oss-prow google-oss-prow bot added the lgtm label Jan 26, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abmarcum, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel enabled auto-merge (squash) January 26, 2023 21:12
@google-oss-prow google-oss-prow bot removed the lgtm label Jan 26, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 560f9098-f9d1-44a4-859e-f7fe1edd0cee

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2933/head:pr_2933 && git checkout pr_2933
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-3975cf6-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9c27f238-0786-4246-9346-0a4da316acc5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2933/head:pr_2933 && git checkout pr_2933
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-0eb00ae-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e0a3ec22-f972-44c1-aa5b-56da7ba40e5c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2933/head:pr_2933 && git checkout pr_2933
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-891fa3c-amd64

@markmandel markmandel merged commit f63ab38 into googleforgames:main Jan 26, 2023
igooch pushed a commit to igooch/agones that referenced this pull request Jan 31, 2023
@abmarcum @igooch
Allocation Endpoint: Fix Makefile to correctly call docker build (goo…
63adaa0 
…gleforgames#2933)

* Modify Makefile call of Dockerfile to fix docker build

* Incremented allocation endpoint version number for the containter image
@Kalaiselvi84 Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@markmandel markmandel

Labels
approved kind/feature New features for Agones size/S
Projects
None yet
Milestone
1.30.0
Development

Successfully merging this pull request may close these issues.
4 participants
@abmarcum @agones-bot @markmandel @Kalaiselvi84