Allow 30m more to acquire consul lock #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We seem to be having more frequent consul lock timeouts on CI. Best guess, this is a bandwidth issue of all PRs using the same e2e clusters and a higher number of PRs, plus probably some organic growth in e2e length. This PR is a stop-gap: * Bumps the consul lock timeout from 1h to 1.5h - basically "wait our turn" for longer. * Bumps the whole build timeout from 2h to 2.5h. I assume the whole build has a generous timeout to allow for the image build, etc, prior to e2es, so kept the increase here 1:1. * Bumps the queue TTL from (default) 1h to 6h. This is a generous bump to allow builds to hang out longer in the queue.
zmerlynn
force-pushed
the
consul-lock-timing
branch
from
aa412e3
to
57125df
Compare
gongmax
approved these changes
Jan 24, 2023
markmandel
approved these changes
Jan 24, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, markmandel, zmerlynn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Succeeded 👏 Build Id: 245386bc-e428-4c30-82a8-b4386f1ebe69 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: 34c4f7cb-32ed-4354-aa59-38657a1a4547 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
igooch
pushed a commit
to igooch/agones
that referenced
this pull request
Jan 31, 2023
We seem to be having more frequent consul lock timeouts on CI. Best guess, this is a bandwidth issue of all PRs using the same e2e clusters and a higher number of PRs, plus probably some organic growth in e2e length. This PR is a stop-gap: * Bumps the consul lock timeout from 1h to 1.5h - basically "wait our turn" for longer. * Bumps the whole build timeout from 2h to 2.5h. I assume the whole build has a generous timeout to allow for the image build, etc, prior to e2es, so kept the increase here 1:1. * Bumps the queue TTL from (default) 1h to 6h. This is a generous bump to allow builds to hang out longer in the queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seem to be having more frequent consul lock timeouts on CI. Best guess, this is a bandwidth issue of all PRs using the same e2e clusters and a higher number of PRs, plus probably some organic growth in e2e length. This PR is a stop-gap:
Bumps the consul lock timeout from 1h to 1.5h - basically "wait our turn" for longer.
Bumps the whole build timeout from 2h to 2.5h. I assume the whole build has a generous timeout to allow for the image build, etc, prior to e2es, so kept the increase here 1:1.